remove unnecessary CacheAllUsedNoteSkins calls; this is all done in NoteField::Init now

stepmania/src/NoteField.h

@@ -32,7 +32,6 @@ public:
 	int	m_iBeginMarker, m_iEndMarker;	// only used with MODE_EDIT
 
 	void FadeToFail();
-	void CacheAllUsedNoteSkins();
 	void CacheNoteSkin( CString skin );
 
 	void Step( int iCol, TapNoteScore score );
@@ -43,6 +42,8 @@ public:
 	void RefreshBeatToNoteSkin();
 
 protected:
+	void CacheAllUsedNoteSkins();
+
 	void DrawBeatBar( const float fBeat );
 	void DrawMarkerBar( int fBeat );
 	void DrawAreaHighlight( int iStartBeat, int iEndBeat );

stepmania/src/Player.cpp

@@ -1394,11 +1394,6 @@ float Player::GetMaxStepDistanceSeconds()
 	return GAMESTATE->m_SongOptions.m_fMusicRate * ADJUSTED_WINDOW(Boo);
 }
 
-void Player::CacheAllUsedNoteSkins()
-{
-	m_pNoteField->CacheAllUsedNoteSkins();
-}
-
 void Player::FadeToFail()
 {
 	if( m_pNoteField )

stepmania/src/Player.h

@@ -55,8 +55,6 @@ public:
 
 	static float GetMaxStepDistanceSeconds();
 
-	void CacheAllUsedNoteSkins();
-
 	NoteData m_NoteData;
 
 protected:

stepmania/src/ScreenGameplay.cpp

@@ -695,7 +695,7 @@ void ScreenGameplay::Init()
 		}
 	}
 
-	FOREACH_PlayerNumber(pn)
+	FOREACH_EnabledPlayer(pn)
 		m_Player[pn].Init( 
 			PLAYER_TYPE,
 			GAMESTATE->m_pPlayerState[pn], 
@@ -867,9 +867,6 @@ void ScreenGameplay::SetupSong( PlayerNumber p, int iSongIndex )
 	// we'll do it on the first update and skip.
 	m_Player[p].ApplyWaitingTransforms();
 
-	/* Now that course options are applied, load any needed note skins and unload old ones. */
-	m_Player[p].CacheAllUsedNoteSkins();
-
 	/* Update attack bOn flags. */
 	GAMESTATE->Update(0);
 	GAMESTATE->RebuildPlayerOptionsFromActiveAttacks( p );