actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

minihold hack

Browse Source
This commit is contained in:
AJ Kelly
2010-08-11 01:33:16 -05:00
parent c8ca3a2a24
commit e2f424e99d
2 changed files with 35 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Docs/Changelog_sm-ssc.txt
+23 -2
View File
@@ -10,9 +10,30 @@ supported but exist anyways.)
_____________________________________________________________________________
================================================================================
sm-ssc v1.0 Release Candidate 2 | 2010xxxx
sm-ssc v1.0 Release Candidate 2 | 201008xx
--------------------------------------------------------------------------------
(Miniholds bug must be fixed before this can be released)
20100811
--------
* [Player] Implement a hack for miniholds until a proper solution can be found.
20100810
--------
[ScreenNetEvaluation]
* Replace hardcoded rainbow effect with UserTier02OrBetterCommand.
* Added Difficulty and Steps param to UpdateNetEvalStats message. The
beginning of custom-themable online stuff begins.
[ScreenNetSelectMusic]
* Started to port SampleMusicPreviewMode from ScreenSelectMusic.
* Changed MusicWheel metrics to read from OnlineMusicWheel instead.
* Added section, roulette, and random music (not used yet).
* Stop the music when reaching a section.
20100808
--------
* [ScreenDebugOverlay] force sm-ssc to read the OnCommand for ButtonText,
FunctionText and PageText.
20100807
--------
src/Player.cpp
+12 -4
View File
@@ -850,7 +850,7 @@ void Player::Update( float fDeltaTime )
{
if( !vHoldNotesToGradeTogether.empty() )
{
//LOG->Trace( ssprintf("UpdateHoldNotes; %i != %i || !judge holds on same row together",iRow,iRowOfLastHoldNote) );
LOG->Trace( ssprintf("UpdateHoldNotes; %i != %i || !judge holds on same row together",iRow,iRowOfLastHoldNote) );
UpdateHoldNotes( iSongRow, fDeltaTime, vHoldNotesToGradeTogether );
vHoldNotesToGradeTogether.clear();
}
@@ -861,7 +861,7 @@ void Player::Update( float fDeltaTime )
if( !vHoldNotesToGradeTogether.empty() )
{
//LOG->Trace("UpdateHoldNotes since !vHoldNotesToGradeTogether.empty()");
LOG->Trace("UpdateHoldNotes since !vHoldNotesToGradeTogether.empty()");
UpdateHoldNotes( iSongRow, fDeltaTime, vHoldNotesToGradeTogether );
vHoldNotesToGradeTogether.clear();
}
@@ -1010,7 +1010,16 @@ void Player::UpdateHoldNotes( int iSongRow, float fDeltaTime, vector<TrackRowTap
bool bInitiatedNote;
if( REQUIRE_STEP_ON_HOLD_HEADS )
bInitiatedNote = bSteppedOnHead;
{
// XXX HACK: Miniholds (a 192nd length hold) will not always register
// as Held, even if you hit the note. This is considered a major
// roadblock to adoption, so until a proper fix is found,
// DON'T REMOVE THIS HACK! -aj
if( iMaxEndRow-iStartRow <= 1 )
bInitiatedNote = true;
else
bInitiatedNote = bSteppedOnHead;
}
else
bInitiatedNote = true;
@@ -2021,7 +2030,6 @@ void Player::StepStrumHopo( int col, int row, const RageTimer &tm, bool bHeld, b
case TapNote::hold_head:
// oh wow, this was causing the trigger before the hold heads
// bug. (It was fNoteOffset > 0.f before) -DaisuMaster
// todo: make this part a metric or a preference
if( !REQUIRE_STEP_ON_HOLD_HEADS && fNoteOffset <= GetWindowSeconds( TW_W5 ) )
{
score = TNS_W1;