Don't use a heartbeat in the worker thread. Many platforms' timed event wait functions (most notoriously Linux) spin instead of blocking, causing performance hell (this is the source of the issues recently uncovered by LowLevelWindow_X11). This means we should avoid heartbeats in worker threads whenever possible. Strangely, this also fixed an obscure deadlock on quit...
This commit is contained in:
@@ -110,7 +110,6 @@ ThreadedMemoryCardWorker::ThreadedMemoryCardWorker():
|
||||
{
|
||||
m_pDriver = MakeMemoryCardDriver();
|
||||
m_MountThreadState = detect_and_mount;
|
||||
SetHeartbeat( 0.1f );
|
||||
|
||||
StartThread();
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user