[PlayerStageStats] Hitting a mine no longer gives you full combo.

TODO: make this work with [Gameplay] MineHitIncrementsMissCombo metric
2011-11-25 17:27:36 -06:00
parent b141db3f55
commit d46db6e9c0
2 changed files with 9 additions and 1 deletions
@@ -8,6 +8,10 @@ ________________________________________________________________________________
 StepMania 5.0 $next | 20111xxx
 --------------------------------------------------------------------------------

+2011/11/25
+----------
+* [PlayerStageStats] Hitting a mine no longer gives you full combo. [AJ]
+
 2011/11/24
 ----------
 * [PlayerStageStats] Added GetFailed and GetNumControllerSteps Lua bindings. [AJ]
@@ -529,7 +529,11 @@ bool PlayerStageStats::FullComboOfScore( TapNoteScore tnsAllGreaterOrEqual ) con
 		if( m_iTapNoteScores[i] > 0 )
 			return false;
 	}
-	
+
+	// hit any mines? It's not a full combo.
+	if( m_iTapNoteScores[TNS_HitMine] > 0 )
+		return false;
+
 	// If has at least one of the judgments equal to or above, then is a full combo.
 	for( int i=tnsAllGreaterOrEqual; i<NUM_TapNoteScore; i++ )
 	{