actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Removing dynamic note skin change support during courses

Browse Source 
and battle.

 - It's very rarely used.
 - It requires authoring new note skins just to use it, which is too
   time-consuming for the value of the feature.
 - Colorblind players may pick a note skin that they can read.  The option
   to do this should always be available, and not overridden by courses,
   or they're not going to be able to read it.
 - The code is extremely complicated and ugly, and breaks very often.

Spring cleaning in January ...
This commit is contained in:
Glenn Maynard
2006-01-12 19:22:08 +00:00
parent b52fe82827
commit c682db354e
1 changed files with 7 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files
stepmania/src/GameState.cpp
+7 -46
View File
@@ -1116,45 +1116,17 @@ void GameState::GetAllUsedNoteSkins( vector<CString> &out ) const
{
out.push_back( m_pPlayerState[pn]->m_PlayerOptions.m_sNoteSkin );
switch( this->m_PlayMode )
{
case PLAY_MODE_BATTLE:
case PLAY_MODE_RAVE:
for( int al=0; al<NUM_ATTACK_LEVELS; al++ )
{
const Character *ch = this->m_pCurCharacters[pn];
ASSERT( ch );
const CString* asAttacks = ch->m_sAttacks[al];
for( int att = 0; att < NUM_ATTACKS_PER_LEVEL; ++att )
{
PlayerOptions po;
po.FromString( asAttacks[att] );
out.push_back( po.m_sNoteSkin );
}
}
}
/* Add note skins that are used in courses. */
if( this->IsCourseMode() )
{
FOREACH_EnabledPlayer(pn)
const Trail *pTrail = this->m_pCurTrail[pn];
ASSERT( pTrail );
FOREACH_CONST( TrailEntry, pTrail->m_vEntries, e )
{
const Trail *pTrail = this->m_pCurTrail[pn];
ASSERT( pTrail );
FOREACH_CONST( TrailEntry, pTrail->m_vEntries, e )
{
AttackArray a;
e->GetAttackArray( a );
for( unsigned j=0; j<a.size(); j++ )
{
const Attack &mod = a[j];
PlayerOptions po;
po.FromString( mod.sModifiers );
out.push_back( po.m_sNoteSkin );
}
}
PlayerOptions po;
po.FromString( e->Modifiers );
out.push_back( po.m_sNoteSkin );
}
}
}
@@ -1162,17 +1134,6 @@ void GameState::GetAllUsedNoteSkins( vector<CString> &out ) const
/* Remove duplicates. */
sort( out.begin(), out.end() );
out.erase( unique( out.begin(), out.end() ), out.end() );
/* Hack: NoteSkin "default" is never applied as an attack, so don't
* waste memory preloading it. */
for( unsigned i = 0; i < out.size(); ++i )
{
if( !out[i].CompareNoCase("default") || out[i] == "" )
{
out.erase( out.begin()+i, out.begin()+i+1 );
--i;
}
}
}
/* From NoteField: */