Attempted fix of Tick Holds
NoteDataUtil::GetTotalHoldTicks() was not counting the last tick of holds which ended on the last row of the song. Extended the range to include the last row. NoteDataUtil::GetTotalHoldTicks() was counting number of rows held, when it should only count 1 regardless of number( at least to mimic pump ) Player::CrossedRows() was assuming a constant tick rate over the crossed rows, leading to potentially inaccurate tick counts. Pump holds were counting "HoldNote_Held" due to capitalization in the metrics. Fixed metrics and made "IsGame" function case insensitive.
This commit is contained in:
@@ -8,7 +8,7 @@ local function CurGameName()
|
||||
end
|
||||
|
||||
-- Check the active game mode against a string. Cut down typing this in metrics.
|
||||
function IsGame(str) return CurGameName() == str end
|
||||
function IsGame(str) return CurGameName():lower() == str:lower() end
|
||||
|
||||
-- GetExtraColorThreshold()
|
||||
-- [en] returns the difficulty threshold in meter
|
||||
|
||||
Reference in New Issue
Block a user