actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ReloadFromSongDir: fix error in Group offset application logic

Browse Source 
When the group can't be found, m_SongTiming is updated instead of mNewSteps[id]->m_Timing. This seems to be an unintentional error, because the non-failure case and surrounding code properly reference mNewSteps[id]->m_Timing.
This commit is contained in:
sukibaby
2025-06-22 20:43:56 -07:00
committed by teejusb
parent 39c40d09e4
commit a12f60d28b
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Song.cpp
+1 -1
View File
@@ -519,7 +519,7 @@ bool Song::ReloadFromSongDir( RString sDir )
}
else
{
m_SongTiming.m_fBeat0GroupOffsetInSeconds = PREFSMAN->m_DefaultSyncOffset == SyncOffset_NULL ? 0 : -0.009;
mNewSteps[id]->m_Timing.m_fBeat0GroupOffsetInSeconds = PREFSMAN->m_DefaultSyncOffset == SyncOffset_NULL ? 0 : -0.009;
LOG->Warn("Song %s has no group, using default sync offset.", m_sMainTitle.c_str());
}
}