From a12f60d28b60b33bde7a4101de2f5906750f8aac Mon Sep 17 00:00:00 2001 From: sukibaby <163092272+sukibaby@users.noreply.github.com> Date: Sun, 22 Jun 2025 20:43:56 -0700 Subject: [PATCH] ReloadFromSongDir: fix error in Group offset application logic When the group can't be found, m_SongTiming is updated instead of mNewSteps[id]->m_Timing. This seems to be an unintentional error, because the non-failure case and surrounding code properly reference mNewSteps[id]->m_Timing. --- src/Song.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Song.cpp b/src/Song.cpp index 6e499c677c..142002b54b 100644 --- a/src/Song.cpp +++ b/src/Song.cpp @@ -519,7 +519,7 @@ bool Song::ReloadFromSongDir( RString sDir ) } else { - m_SongTiming.m_fBeat0GroupOffsetInSeconds = PREFSMAN->m_DefaultSyncOffset == SyncOffset_NULL ? 0 : -0.009; + mNewSteps[id]->m_Timing.m_fBeat0GroupOffsetInSeconds = PREFSMAN->m_DefaultSyncOffset == SyncOffset_NULL ? 0 : -0.009; LOG->Warn("Song %s has no group, using default sync offset.", m_sMainTitle.c_str()); } }