actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Verify that we won't call a method on a non-existant element.

Browse Source 
This seems to be the root of a handfull of crashes.
This commit is contained in:
Charles Lohr
2004-12-07 05:53:03 +00:00
parent c3f154dd27
commit 9e8cbeb8df
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
stepmania/src/NetworkSyncServer.cpp
+10 -7
View File
@@ -515,7 +515,8 @@ void StepManiaLanServer::SendStatsToClients()
void StepManiaLanServer::SendNetPacket(const unsigned int client, PacketFunctions& Packet) void StepManiaLanServer::SendNetPacket(const unsigned int client, PacketFunctions& Packet)
{ {
Client[client]->clientSocket.SendPack((char*)Packet.Data, Packet.Position); if ( client < Client.size() )
Client[client]->clientSocket.SendPack((char*)Packet.Data, Packet.Position);
} }
void StepManiaLanServer::StatsNameColumn(PacketFunctions &data, vector<LanPlayer*> &playresPtr) void StepManiaLanServer::StatsNameColumn(PacketFunctions &data, vector<LanPlayer*> &playresPtr)
@@ -592,7 +593,8 @@ void StepManiaLanServer::NewClientCheck()
void StepManiaLanServer::SendValue(uint8_t value, const unsigned int clientNum) void StepManiaLanServer::SendValue(uint8_t value, const unsigned int clientNum)
{ {
Client[clientNum]->clientSocket.SendPack((char*)&value, sizeof(uint8_t)); if ( clientNum < Client.size() )
Client[clientNum]->clientSocket.SendPack((char*)&value, sizeof(uint8_t));
} }
void StepManiaLanServer::AnalizeChat(PacketFunctions &Packet, const unsigned int clientNum) void StepManiaLanServer::AnalizeChat(PacketFunctions &Packet, const unsigned int clientNum)
@@ -814,11 +816,12 @@ void StepManiaLanServer::ServerChat(const CString& message)
bool StepManiaLanServer::CheckConnection(const unsigned int clientNum) bool StepManiaLanServer::CheckConnection(const unsigned int clientNum)
{ {
//If there is an error close the socket. //If there is an error close the socket.
if (Client[clientNum]->clientSocket.IsError()) if ( clientNum < Client.size() )
{ if (Client[clientNum]->clientSocket.IsError())
Disconnect(clientNum); {
return false; Disconnect(clientNum);
} return false;
}
return true; return true;
} }