fix TODO

2005-01-09 22:28:31 +00:00
parent d7aba9fd68
commit 9aaaea6e7e
1 changed files with 1 additions and 2 deletions
@@ -126,10 +126,9 @@ void NoteDataUtil::LoadFromSMNoteDataString( NoteData &out, CString sSMNoteData
 				{
 					p++;

-					// TODO: this buffer could overflow
 					char szModifiers[256] = "";
 					float fDurationSeconds = 0;
-					if( 2 == sscanf( p, "%[^:]:%f}", szModifiers, &fDurationSeconds ) )	// not fatal if this fails due to malformed data
+					if( sscanf( p, "%255[^:]:%f}", szModifiers, &fDurationSeconds ) == 2 )	// not fatal if this fails due to malformed data
 					{
 						tn.type = TapNote::attack;
 						tn.sAttackModifiers = szModifiers;