From 9aaaea6e7e2296e3ec5766cfd3b758b67b8cc065 Mon Sep 17 00:00:00 2001
From: Glenn Maynard <gmaynard@users.sourceforge.net>
Date: Sun, 9 Jan 2005 22:28:31 +0000
Subject: [PATCH] fix TODO

---
 stepmania/src/NoteDataUtil.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/stepmania/src/NoteDataUtil.cpp b/stepmania/src/NoteDataUtil.cpp
index 0afbf164ff..c91eecd1ef 100644
--- a/stepmania/src/NoteDataUtil.cpp
+++ b/stepmania/src/NoteDataUtil.cpp
@@ -126,10 +126,9 @@ void NoteDataUtil::LoadFromSMNoteDataString( NoteData &out, CString sSMNoteData
 				{
 					p++;
 
-					// TODO: this buffer could overflow
 					char szModifiers[256] = "";
 					float fDurationSeconds = 0;
-					if( 2 == sscanf( p, "%[^:]:%f}", szModifiers, &fDurationSeconds ) )	// not fatal if this fails due to malformed data
+					if( sscanf( p, "%255[^:]:%f}", szModifiers, &fDurationSeconds ) == 2 )	// not fatal if this fails due to malformed data
 					{
 						tn.type = TapNote::attack;
 						tn.sAttackModifiers = szModifiers;