remove Course::HasCourseDifficulty

stepmania/src/Course.cpp

@@ -470,25 +470,9 @@ void Course::AutogenOniFromArtist( CString sArtistName, CString sArtistNameTrans
 	}
 }
 
-/*
- * Difficult courses do the following:
- *
- * For entries with a meter range, bump it up by DIFFICULT_METER_CHANGE;
- * eg. 3..6 -> 5..8, with a minimum no higher than MAX_BOTTOM_RANGE.
- *
- * For entries with a difficulty class, use notes one class harder, if they
- * exist. This way, if a static song entry points to a difficulty, we'll always
- * play that song, even if we're on difficult and harder notes don't exist.  (The
- * exception is a static song entry with a meter range, but that's not very useful.)
- */
-bool Course::HasCourseDifficulty( StepsType st, CourseDifficulty cd ) const
-{
-	return GetTrail( st, cd ) != NULL;
-}
-
 bool Course::IsPlayableIn( StepsType st ) const
 {
-	return HasCourseDifficulty( st, COURSE_DIFFICULTY_REGULAR );
+	return GetTrail( st, COURSE_DIFFICULTY_REGULAR ) != NULL;
 }
 
 static vector<Song*> GetFilteredBestSongs( StepsType st )
@@ -834,9 +818,6 @@ void Course::GetTrails( vector<Trail*> &AddTo, StepsType st ) const
 {
 	FOREACH_CourseDifficulty( cd )
 	{
-		if( !HasCourseDifficulty(st, cd) )
-			continue;
-
 		Trail *pTrail = GetTrail( st, cd );
 		if( pTrail == NULL )
 			continue;

stepmania/src/Course.h

@@ -102,7 +102,6 @@ public:
 	bool AllSongsAreFixed() const;
 
 	int GetEstimatedNumStages() const { return m_entries.size(); }
-	bool HasCourseDifficulty( StepsType st, CourseDifficulty cd ) const;
 	bool IsPlayableIn( StepsType st ) const;
 	bool CourseHasBestOrWorst() const;
 	RageColor GetColor() const;

stepmania/src/GameState.cpp

@@ -1740,7 +1740,7 @@ bool GameState::ChangePreferredCourseDifficulty( PlayerNumber pn, int dir )
 			return false;
 		if( asDiff.find(cd) == asDiff.end() )
 			continue; /* not available */
-		if( !pCourse || pCourse->HasCourseDifficulty( GAMESTATE->GetCurrentStyleDef()->m_StepsType, cd ) )
+		if( !pCourse || pCourse->GetTrail( GAMESTATE->GetCurrentStyleDef()->m_StepsType, cd ) )
 			break;
 	}
 

stepmania/src/Profile.cpp

@@ -301,9 +301,6 @@ int Profile::GetPossibleCourseDancePointsForStepsType( StepsType st ) const
 
 			FOREACH_ShownCourseDifficulty( cd )
 			{
-				if( !pCourse->HasCourseDifficulty(st,cd) )
-					continue;
-
 				Trail* pTrail = pCourse->GetTrail(st,cd);
 				if( pTrail == NULL )
 					continue;