actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Song::GetFileHash cleanup

Browse Source 
Implement a range-based loop instead of a big list of if statements.

& prefer ssc to sm to all else

Song::GetFileHash: Fix indentation
This commit is contained in:
sukibaby
2025-05-09 10:48:37 -07:00
committed by teejusb
parent e84b774166
commit 60f57cd337
1 changed files with 13 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Song.cpp
+13 -19
View File
@@ -1767,27 +1767,21 @@ RString Song::GetCacheFile(RString sType)
RString Song::GetFileHash() RString Song::GetFileHash()
{ {
static const std::vector<RString> extensions = {
"ssc", "sm", "dwi", "sma", "bms", "ksf", "json", "jso"
};
if (m_sFileHash.empty()) { if (m_sFileHash.empty()) {
RString sPath = SetExtension(GetSongFilePath(), "sm"); for (const RString& ext : extensions) {
if (!IsAFile(sPath)) RString sPath = SetExtension(GetSongFilePath(), ext);
sPath = SetExtension(GetSongFilePath(), "dwi"); if (IsAFile(sPath)) {
if (!IsAFile(sPath)) m_sFileHash = BinaryToHex(CRYPTMAN->GetSHA1ForFile(sPath));
sPath = SetExtension(GetSongFilePath(), "sma"); return m_sFileHash;
if (!IsAFile(sPath)) }
sPath = SetExtension(GetSongFilePath(), "bms"); }
if (!IsAFile(sPath))
sPath = SetExtension(GetSongFilePath(), "ksf");
if (!IsAFile(sPath))
sPath = SetExtension(GetSongFilePath(), "json");
if (!IsAFile(sPath))
sPath = SetExtension(GetSongFilePath(), "jso");
if (!IsAFile(sPath))
sPath = SetExtension(GetSongFilePath(), "ssc");
if (IsAFile(sPath))
m_sFileHash = BinaryToHex(CRYPTMAN->GetSHA1ForFile(sPath));
else
m_sFileHash = "";
} }
m_sFileHash = "";
return m_sFileHash; return m_sFileHash;
} }