actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix some type mismatches that cause stack corruption in VC7.

Browse Source 
Never memset(0) a non-POD type (eg. a vector).
This commit is contained in:
Glenn Maynard
2003-05-06 21:10:21 +00:00
parent f8eba60bd8
commit 60a13f806d
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
stepmania/src/Model.cpp
+3 -2
View File
@@ -51,7 +51,8 @@ bool Model::LoadMilkshapeAscii( CString sPath )
Clear ();
m_pModel = new msModel;
memset (m_pModel, 0, sizeof (msModel));
// Never zero out a non-POD data type.
// memset (m_pModel, 0, sizeof (msModel));
bool bError = false;
char szLine[256];
@@ -217,7 +218,7 @@ bool Model::LoadMilkshapeAscii( CString sPath )
word nIndices[3];
word nNormalIndices[3];
if (sscanf (szLine, "%d %d %d %d %d %d %d %d",
if (sscanf (szLine, "%d %hd %hd %hd %hd %hd %hd %d",
&nFlags,
&nIndices[0], &nIndices[1], &nIndices[2],
&nNormalIndices[0], &nNormalIndices[1], &nNormalIndices[2],