working on timeout filesystem layer (not done)

This commit is contained in:
Glenn Maynard
2005-01-26 22:07:59 +00:00
parent 1b49d06b5d
commit 476c27474d
2 changed files with 440 additions and 0 deletions
+387
View File
@@ -0,0 +1,387 @@
/*
* This is a filesystem wrapper driver. To use it, mount it on top of another filesystem at a
* different mountpoint. For example, mount the local path "d:/" as a normal directory to
* /cdrom-native:
*
* FILEMAN->Mount( "dir", "d:/", "/cdrom-native" );
*
* and then mount a timeout filesystem on top of that:
*
* FILEMAN->Mount( "timeout", "/cdrom-native", "/cdrom-timeout" );
*
* and do all access to the device at /cdrom-timeout.
*
* A common problem with accessing devices, such as CDROMs or flaky pen drives, is that they
* can take a very long time to fail under error conditions. A single request may have a
* timeout of 500ms, but a single operation may do many requests. The system will usually
* retry operations, and we want to allow it to do so, but we don't want the high-level
* operation to take too long as a whole.
*
* There's no portable way to abort a running filesystem operation. In Unix, you may be
* able to use SIGALRM, which should cause a running operation to fail with EINTR, but
* I don't trust that, and it's not portable.
*
* This driver abstracts all access to another driver, and enforces high-level timeouts.
* Operations are run in a separate thread. If an operation takes too long to complete,
* the main thread will see it fail. The operation in the thread will actually continue;
* it will time out for real eventually. To prevent accumulation of failed threads, if
* an operation times out, we'll refuse all further access until all operations have
* finished and exited. (Load a separate driver for each device, so if one device fails,
* others continue to function.)
*
* All operations must run in the thread, including retrieving directory lists, Open()
* and deleting file objects. Read/write operations are copied through an intermediate
* buffer, so we don't clobber stuff if the operation times out, the call returns and the
* operation then completes.
*
* Unmounting the filesystem will wait for all timed-out operations to complete.
*
* This class is not threadsafe; do not access files on this filesystem from multiple
* threads simultaneously.
*/
#include "global.h"
#include "RageFileDriverTimeout.h"
#include "RageUtil_FileDB.h"
#include "RageLog.h"
enum ThreadRequest
{
REQ_POPULATE_FILE_SET,
REQ_FLUSH_DIR_CACHE,
REQ_SHUTDOWN,
REQ_INVALID,
NUM_REQUESTS,
};
/* This is the class that does most of the work. */
class ThreadedFileWorker
{
public:
ThreadedFileWorker( CString sDriverName, RageFileDriver *pChildDriver );
~ThreadedFileWorker();
void SetTimeout( float fSeconds );
bool FlushDirCache( const CString &sPath );
bool PopulateFileSet( FileSet &fs, const CString &sPath );
private:
static int StartWorkerMain( void *pThis ) { ((ThreadedFileWorker *) (pThis))->WorkerMain(); return 0; }
void WorkerMain();
/* Run the given request. Return true if the operation completed, false on timeout.
* All other return values (including error returns from the request) are returned
* below. */
bool DoRequest( ThreadRequest r );
RageThread m_WorkerThread;
RageEvent m_WorkerEvent;
RageFileDriver *m_pChildDriver;
RageTimer m_Timeout;
/* All requests: */
ThreadRequest m_Request;
bool m_bRequestFinished;
bool m_bTimedOut;
/* REQ_POPULATE_FILE_SET, REQ_FLUSH_DIR_CACHE: */
CString m_sRequestPath; /* in */
/* REQ_POPULATE_FILE_SET: */
FileSet m_RequestOutput; /* out */
};
static vector<ThreadedFileWorker *> g_apWorkers;
static RageMutex g_apWorkersMutex("WorkersMutex");
/* Set the timeout length, and reset the timer. */
void RageFileDriverTimeout::SetTimeout( float fSeconds )
{
g_apWorkersMutex.Lock();
for( unsigned i = 0; i < g_apWorkers.size(); ++i )
g_apWorkers[i]->SetTimeout( fSeconds );
g_apWorkersMutex.Unlock();
}
ThreadedFileWorker::ThreadedFileWorker( CString sDriverName, RageFileDriver *pChildDriver ):
m_WorkerEvent( sDriverName + "worker event" )
{
m_Request = REQ_INVALID;
m_bTimedOut = false;
m_pChildDriver = pChildDriver;
m_WorkerThread.SetName( "ThreadedFileWorker fileset worker \"" + sDriverName + "\"" );
m_WorkerThread.Create( StartWorkerMain, this );
g_apWorkersMutex.Lock();
g_apWorkers.push_back( this );
g_apWorkersMutex.Unlock();
}
ThreadedFileWorker::~ThreadedFileWorker()
{
/* If we're timed out, wait. */
m_WorkerEvent.Lock();
if( m_bTimedOut )
{
LOG->Trace( "Waiting for timed-out fs \"%s\" to complete ..." );
while( m_bTimedOut )
m_WorkerEvent.Wait();
}
m_WorkerEvent.Unlock();
/* Disable the timeout. This will ensure that we really wait for the worker
* thread to shut down. */
SetTimeout( -1 );
/* Shut down. */
DoRequest( REQ_SHUTDOWN );
m_WorkerThread.Wait();
/* Unregister ourself. */
g_apWorkersMutex.Lock();
for( unsigned i = 0; i < g_apWorkers.size(); ++i )
{
if( g_apWorkers[i] == this )
{
g_apWorkers.erase( g_apWorkers.begin()+i );
break;
}
}
g_apWorkersMutex.Unlock();
}
void ThreadedFileWorker::SetTimeout( float fSeconds )
{
m_WorkerEvent.Lock();
if( fSeconds == -1 )
m_Timeout.SetZero();
else
{
m_Timeout.Touch();
m_Timeout += fSeconds;
}
m_WorkerEvent.Unlock();
}
bool ThreadedFileWorker::DoRequest( ThreadRequest r )
{
ASSERT( !m_bTimedOut );
ASSERT( m_Request == REQ_INVALID );
/* Set the request, and wake up the worker thread. */
m_WorkerEvent.Lock();
m_Request = r;
m_WorkerEvent.Broadcast();
/* Wait for it to complete or time out. */
bool bTimedOut = false;
while( !m_bRequestFinished && !m_bTimedOut )
bTimedOut = !m_WorkerEvent.Wait( &m_Timeout );
/* Set m_bTimedOut true. It'll be set to false when the operation actually
* completes. */
if( bTimedOut )
m_bTimedOut = true;
m_WorkerEvent.Unlock();
return !bTimedOut;
}
void ThreadedFileWorker::WorkerMain()
{
while(1)
{
m_WorkerEvent.Lock();
while( m_Request == REQ_INVALID )
m_WorkerEvent.Wait();
const ThreadRequest r = m_Request;
m_Request = REQ_INVALID;
m_WorkerEvent.Unlock();
/* We have a request. */
switch( r )
{
case REQ_POPULATE_FILE_SET:
ASSERT( !m_bRequestFinished );
ASSERT( !m_sRequestPath.empty() );
m_RequestOutput = FileSet();
m_pChildDriver->FDB->GetFileSetCopy( m_sRequestPath, m_RequestOutput );
break;
case REQ_FLUSH_DIR_CACHE:
m_pChildDriver->FlushDirCache( m_sRequestPath );
break;
case REQ_SHUTDOWN:
break;
}
m_WorkerEvent.Lock();
/* If we timed out, clear the time-out flag, indicating that we can work
* once again. */
if( !m_bTimedOut )
m_bRequestFinished = true;
/* We're finished. Wake up the requester. */
m_WorkerEvent.Broadcast();
m_WorkerEvent.Unlock();
if( r == REQ_SHUTDOWN )
break;
}
}
bool ThreadedFileWorker::PopulateFileSet( FileSet &fs, const CString &sPath )
{
/* If we're currently in a timed-out state, fail. */
if( m_bTimedOut )
return false;
/* Fill in a different FileSet; copy the results in on success. */
m_sRequestPath = sPath;
m_bRequestFinished = false;
/* Kick off the worker thread, and wait for it to finish. */
if( !DoRequest( REQ_POPULATE_FILE_SET ) )
{
LOG->Trace( "PopulateFileSet(%s) timed out", sPath.c_str() );
return false;
}
fs = m_RequestOutput;
return true;
}
bool ThreadedFileWorker::FlushDirCache( const CString &sPath )
{
/* If we're currently in a timed-out state, fail. */
if( m_bTimedOut )
return false;
m_sRequestPath = sPath;
/* Kick off the worker thread, and wait for it to finish. */
if( !DoRequest( REQ_FLUSH_DIR_CACHE ) )
{
LOG->Trace( "FlushDirCache(%s) timed out", sPath.c_str() );
return false;
}
return true;
}
/* This FilenameDB runs PopulateFileSet in the worker thread. */
class TimedFilenameDB: public FilenameDB
{
public:
TimedFilenameDB()
{
ExpireSeconds = -1;
m_pWorker = NULL;
}
void SetWorker( ThreadedFileWorker *pWorker )
{
ASSERT( pWorker != NULL );
m_pWorker = pWorker;
}
void PopulateFileSet( FileSet &fs, const CString &sPath )
{
ASSERT( m_pWorker != NULL );
m_pWorker->PopulateFileSet( fs, sPath );
}
private:
ThreadedFileWorker *m_pWorker;
};
RageFileDriverTimeout::RageFileDriverTimeout( CString sPath ):
RageFileDriver( new TimedFilenameDB() )
{
/* Grab a reference to the child driver. We'll operate on it directly. */
// XXX let ThreadedFileWorker own m_pChild
m_pChild = FILEMAN->GetFileDriver( sPath );
m_pWorker = new ThreadedFileWorker( sPath, m_pChild );
((TimedFilenameDB *) FDB)->SetWorker( m_pWorker );
}
RageFileBasic *RageFileDriverTimeout::Open( const CString &path, int mode, int &err )
{
// XXX
return m_pChild->Open( path, mode, err );
}
void RageFileDriverTimeout::FlushDirCache( const CString &sPath )
{
if( m_pChild == NULL )
return;
m_pWorker->FlushDirCache( sPath );
}
RageFileDriverTimeout::~RageFileDriverTimeout()
{
delete m_pWorker;
if( m_pChild != NULL )
FILEMAN->ReleaseFileDriver( m_pChild );
}
static struct FileDriverEntry_Timeout: public FileDriverEntry
{
FileDriverEntry_Timeout(): FileDriverEntry( "TIMEOUT" ) { }
RageFileDriver *Create( CString Root ) const { return new RageFileDriverTimeout( Root ); }
} const g_RegisterDriver;
class RageFileObjTimed: public RageFileObj
{
public:
/* By default, pFile will not be freed. */
RageFileObjTimed( RageFileBasic *pOutput );
~RageFileObjTimed();
int GetFileSize() const { return m_pFile->GetFileSize(); }
void DeleteFileWhenFinished() { m_bFileOwned = true; }
protected:
int ReadInternal( void *pBuffer, size_t iBytes ) { SetError( "Not implemented" ); return -1; }
int WriteInternal( const void *pBuffer, size_t iBytes );
int FlushInternal();
RageFileBasic *m_pFile;
bool m_bFileOwned;
};
/*
* Copyright (c) 2005 Glenn Maynard
* All rights reserved.
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the
* "Software"), to deal in the Software without restriction, including
* without limitation the rights to use, copy, modify, merge, publish,
* distribute, and/or sell copies of the Software, and to permit persons to
* whom the Software is furnished to do so, provided that the above
* copyright notice(s) and this permission notice appear in all copies of
* the Software and that both the above copyright notice(s) and this
* permission notice appear in supporting documentation.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
* OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF
* THIRD PARTY RIGHTS. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR HOLDERS
* INCLUDED IN THIS NOTICE BE LIABLE FOR ANY CLAIM, OR ANY SPECIAL INDIRECT
* OR CONSEQUENTIAL DAMAGES, OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS
* OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
* OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
* PERFORMANCE OF THIS SOFTWARE.
*/
+53
View File
@@ -0,0 +1,53 @@
/* RageFileDriverTimeOut - manipulate files with a forced timeout */
#ifndef RAGE_FILE_DRIVER_TIMEOUT_H
#define RAGE_FILE_DRIVER_TIMEOUT_H
#include "RageFileDriver.h"
class ThreadedFileWorker;
class RageFileDriverTimeout: public RageFileDriver
{
public:
RageFileDriverTimeout( CString path );
virtual ~RageFileDriverTimeout();
RageFileBasic *Open( const CString &path, int mode, int &err );
void FlushDirCache( const CString &sPath );
static void SetTimeout( float fSeconds );
static void ResetTimeout() { SetTimeout( -1 ); }
private:
RageFileDriver *m_pChild;
ThreadedFileWorker *m_pWorker;
};
#endif
/*
* Copyright (c) 2005 Glenn Maynard
* All rights reserved.
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the
* "Software"), to deal in the Software without restriction, including
* without limitation the rights to use, copy, modify, merge, publish,
* distribute, and/or sell copies of the Software, and to permit persons to
* whom the Software is furnished to do so, provided that the above
* copyright notice(s) and this permission notice appear in all copies of
* the Software and that both the above copyright notice(s) and this
* permission notice appear in supporting documentation.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
* OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF
* THIRD PARTY RIGHTS. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR HOLDERS
* INCLUDED IN THIS NOTICE BE LIABLE FOR ANY CLAIM, OR ANY SPECIAL INDIRECT
* OR CONSEQUENTIAL DAMAGES, OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS
* OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
* OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
* PERFORMANCE OF THIS SOFTWARE.
*/