fix warnings

stepmania/src/Difficulty.h

@@ -19,7 +19,7 @@ enum Difficulty
 };
 #define FOREACH_Difficulty( dc ) FOREACH_ENUM( Difficulty, NUM_DIFFICULTIES, dc )
 const CString& DifficultyToString( Difficulty dc );
-CString DifficultyToThemedString( Difficulty dc );
+const CString& DifficultyToThemedString( Difficulty dc );
 Difficulty StringToDifficulty( const CString& sDC );
 
 
@@ -29,7 +29,7 @@ typedef Difficulty CourseDifficulty;
 #define FOREACH_ShownCourseDifficulty( cd ) for( Difficulty cd=GetNextShownCourseDifficulty((CourseDifficulty)-1); cd!=DIFFICULTY_INVALID; cd=GetNextShownCourseDifficulty(cd) )
 
 const CString& CourseDifficultyToString( Difficulty dc );
-CString CourseDifficultyToThemedString( Difficulty dc );
+const CString& CourseDifficultyToThemedString( Difficulty dc );
 Difficulty StringToCourseDifficulty( const CString& sDC );
 
 Difficulty GetNextShownCourseDifficulty( Difficulty pn );

stepmania/src/EnumHelper.h

@@ -48,7 +48,7 @@ static const CString EMPTY_STRING;
 
 #define XToThemedString(X, CNT)      \
 	static ThemeMetric<CString> g_##X##Name[CNT]; \
-	CString X##ToThemedString( X x ) \
+	const CString &X##ToThemedString( X x ) \
 	{       \
 		static bool bInitted = false; \
 		if( !bInitted ) { \

stepmania/src/GameConstantsAndTypes.h

@@ -32,7 +32,7 @@ enum RadarCategory
 };
 #define FOREACH_RadarCategory( rc ) FOREACH_ENUM( RadarCategory, NUM_RADAR_CATEGORIES, rc )
 const CString& RadarCategoryToString( RadarCategory cat );
-CString RadarCategoryToThemedString( RadarCategory cat );
+const CString& RadarCategoryToThemedString( RadarCategory cat );
 
 
 
@@ -87,7 +87,7 @@ enum PlayMode
 };
 #define FOREACH_PlayMode( pm ) FOREACH_ENUM( PlayMode, NUM_PLAY_MODES, pm )
 const CString& PlayModeToString( PlayMode pm );
-CString PlayModeToThemedString( PlayMode pm );
+const CString& PlayModeToThemedString( PlayMode pm );
 PlayMode StringToPlayMode( const CString& s );
 
 
@@ -138,7 +138,7 @@ enum TapNoteScore {
 };
 #define FOREACH_TapNoteScore( tns ) FOREACH_ENUM( TapNoteScore, NUM_TAP_NOTE_SCORES, tns )
 const CString& TapNoteScoreToString( TapNoteScore tns );
-CString TapNoteScoreToThemedString( TapNoteScore tns );
+const CString& TapNoteScoreToThemedString( TapNoteScore tns );
 TapNoteScore StringToTapNoteScore( const CString& str );
 
 
@@ -151,7 +151,8 @@ enum HoldNoteScore
 };
 #define FOREACH_HoldNoteScore( hns ) FOREACH_ENUM( HoldNoteScore, NUM_HOLD_NOTE_SCORES, hns )
 const CString& HoldNoteScoreToString( HoldNoteScore hns );
-CString HoldNoteScoreToThemedString( HoldNoteScore hns );
+const CString& HoldNoteScoreToThemedString( HoldNoteScore hns );
+
 HoldNoteScore StringToHoldNoteScore( const CString& str );
 
 
@@ -294,7 +295,7 @@ enum PerDifficultyAward
 };
 #define FOREACH_PerDifficultyAward( pma ) FOREACH_ENUM( PerDifficultyAward, NUM_PER_DIFFICULTY_AWARDS, pma )
 const CString& PerDifficultyAwardToString( PerDifficultyAward pma );
-CString PerDifficultyAwardToThemedString( PerDifficultyAward pma );
+const CString& PerDifficultyAwardToThemedString( PerDifficultyAward pma );
 PerDifficultyAward StringToPerDifficultyAward( const CString& pma );
 
 
@@ -315,7 +316,7 @@ enum PeakComboAward
 };
 #define FOREACH_PeakComboAward( pca ) FOREACH_ENUM( PeakComboAward, NUM_PEAK_COMBO_AWARDS, pca )
 const CString& PeakComboAwardToString( PeakComboAward pma );
-CString PeakComboAwardToThemedString( PeakComboAward pma );
+const CString& PeakComboAwardToThemedString( PeakComboAward pma );
 PeakComboAward StringToPeakComboAward( const CString& pma );