actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix hold note rendering

Browse Source 
Reverses the logic changes done in commits: https://github.com/stepmania/stepmania/commit/567f8363e8dab41a75c9e5a8d307dcf991fb816d and https://github.com/stepmania/stepmania/commit/e96b17015421a0b2777746462838ae6897ea910d
This commit is contained in:
teejusb
2021-08-23 18:11:07 -07:00
parent c4990dd7ac
commit 3111f90b75
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/NoteDisplay.cpp
+4 -5
View File
@@ -471,8 +471,8 @@ bool NoteDisplay::DrawHoldsInRange(const NoteFieldRenderArgs& field_args,
const vector<NoteData::TrackMap::const_iterator>& tap_set)
{
bool any_upcoming = false;
for(vector<NoteData::TrackMap::const_iterator>::const_reverse_iterator tapit=
tap_set.rbegin(); tapit != tap_set.rend(); ++tapit)
for(vector<NoteData::TrackMap::const_iterator>::const_iterator tapit=
tap_set.begin(); tapit != tap_set.end(); ++tapit)
{
const TapNote& tn= (*tapit)->second;
const HoldNoteResult& result= tn.HoldResult;
@@ -538,8 +538,8 @@ bool NoteDisplay::DrawTapsInRange(const NoteFieldRenderArgs& field_args,
{
bool any_upcoming= false;
// draw notes from furthest to closest
for(vector<NoteData::TrackMap::const_iterator>::const_reverse_iterator tapit=
tap_set.rbegin(); tapit != tap_set.rend(); ++tapit)
for(vector<NoteData::TrackMap::const_iterator>::const_iterator tapit=
tap_set.begin(); tapit != tap_set.end(); ++tapit)
{
int tap_row= (*tapit)->first;
const TapNote& tn= (*tapit)->second;
@@ -613,7 +613,6 @@ bool NoteDisplay::DrawTapsInRange(const NoteFieldRenderArgs& field_args,
any_upcoming |= NoteRowToBeat(tap_row) >
m_pPlayerState->GetDisplayedPosition().m_fSongBeat;
// TODO: change to Z Bias, remove clear
if(!PREFSMAN->m_FastNoteRendering)
{
DISPLAY->ClearZBuffer();