Bring [metricClean] up to date.

This commit is contained in:
Jason Felds
2011-04-03 17:38:37 -04:00
7 changed files with 8 additions and 19 deletions
-1
View File
@@ -151,7 +151,6 @@ bool RoomWheel::Select()
{ {
// Since this is not actually an option outside of this wheel, NULL is a good idea. // Since this is not actually an option outside of this wheel, NULL is a good idea.
m_LastSelection = NULL; m_LastSelection = NULL;
// todo: Call a screen with class ScreenTextEntry instead. -aj
ScreenTextEntry::TextEntry( SM_BackFromRoomName, ENTER_ROOM_NAME, "", 255 ); ScreenTextEntry::TextEntry( SM_BackFromRoomName, ENTER_ROOM_NAME, "", 255 );
} }
return false; return false;
-7
View File
@@ -3531,7 +3531,6 @@ void ScreenEdit::HandleStepsInformationChoice( StepsInformationChoice c, const v
switch( c ) switch( c )
{ {
case description: case description:
// todo: Call a screen with class ScreenTextEntry instead. -aj
ScreenTextEntry::TextEntry( ScreenTextEntry::TextEntry(
SM_None, SM_None,
ENTER_NEW_DESCRIPTION, ENTER_NEW_DESCRIPTION,
@@ -3580,8 +3579,6 @@ void ScreenEdit::HandleSongInformationChoice( SongInformationChoice c, const vec
{ {
Song* pSong = GAMESTATE->m_pCurSong; Song* pSong = GAMESTATE->m_pCurSong;
// todo: Call a screen with class ScreenTextEntry instead.
// multiple times in this section, so I'm only saying it here. -aj
switch( c ) switch( c )
{ {
DEFAULT_FAIL(c); DEFAULT_FAIL(c);
@@ -3628,7 +3625,6 @@ void ScreenEdit::HandleTimingDataInformationChoice( TimingDataInformationChoice
{ {
DEFAULT_FAIL( c ); DEFAULT_FAIL( c );
case bpm: case bpm:
// todo: Call a screen with class ScreenTextEntry instead. -aj
ScreenTextEntry::TextEntry( ScreenTextEntry::TextEntry(
SM_BackFromBPMChange, SM_BackFromBPMChange,
ENTER_BPM_VALUE, ENTER_BPM_VALUE,
@@ -3637,7 +3633,6 @@ void ScreenEdit::HandleTimingDataInformationChoice( TimingDataInformationChoice
); );
break; break;
case stop: case stop:
// todo: Call a screen with class ScreenTextEntry instead. -aj
ScreenTextEntry::TextEntry( ScreenTextEntry::TextEntry(
SM_BackFromStopChange, SM_BackFromStopChange,
ENTER_STOP_VALUE, ENTER_STOP_VALUE,
@@ -3646,7 +3641,6 @@ void ScreenEdit::HandleTimingDataInformationChoice( TimingDataInformationChoice
); );
break; break;
case delay: case delay:
// todo: Call a screen with class ScreenTextEntry instead. -aj
ScreenTextEntry::TextEntry( ScreenTextEntry::TextEntry(
SM_BackFromDelayChange, SM_BackFromDelayChange,
ENTER_DELAY_VALUE, ENTER_DELAY_VALUE,
@@ -3687,7 +3681,6 @@ void ScreenEdit::HandleTimingDataInformationChoice( TimingDataInformationChoice
); );
break; break;
case warp: case warp:
// todo: Call a screen with class ScreenTextEntry instead. -aj
ScreenTextEntry::TextEntry( ScreenTextEntry::TextEntry(
SM_BackFromWarpChange, SM_BackFromWarpChange,
ENTER_WARP_VALUE, ENTER_WARP_VALUE,
+2 -2
View File
@@ -25,8 +25,8 @@ void ScreenOptionsExportPackage::Init()
void ScreenOptionsExportPackage::BeginScreen() void ScreenOptionsExportPackage::BeginScreen()
{ {
// Fill m_vsPossibleDirsToExport // Fill m_vsPossibleDirsToExport
// todo: split these out over multiple screens so the scroller // todo: Split these out over multiple screens so the scroller
// isn't so overloaded. -freem // isn't so overloaded. (See ScreenOptionsToggleSongs) -freem
{ {
// Add themes // Add themes
{ {
+1 -2
View File
@@ -809,8 +809,7 @@ void ScreenSelectMaster::MenuStart( const InputEventPlus &input )
mc.ApplyToAllPlayers(); mc.ApplyToAllPlayers();
// We want to be able to broadcast a Start message to the theme, in // We want to be able to broadcast a Start message to the theme, in
// case a themer wants to handle something. -aj // case a themer wants to handle something. -aj
// TODO: Find a way to differentiate this from the message below, for // TODO: Add a param to differentiate this from the message below.
// less ambiguousness?
MESSAGEMAN->Broadcast( (MessageID)(Message_MenuStartP1+pn) ); MESSAGEMAN->Broadcast( (MessageID)(Message_MenuStartP1+pn) );
return; return;
} }
+3 -4
View File
@@ -485,7 +485,7 @@ void ScreenSelectMusic::Input( const InputEventPlus &input )
m_bStepsChosen[input.pn] ) m_bStepsChosen[input.pn] )
return; // ignore return; // ignore
// todo: use mousewheel to scroll MusicWheel -aj // todo: Allow mousewheel to scroll MusicWheel -aj
if( USE_PLAYER_SELECT_MENU ) if( USE_PLAYER_SELECT_MENU )
{ {
@@ -1528,9 +1528,8 @@ void ScreenSelectMusic::AfterStepsOrTrailChange( const vector<PlayerNumber> &vpn
} }
else else
{ {
// I don't like how numbers just stay up there if the current // The numbers shouldn't stay if the current selection is NULL.
// selection is NULL. // todo: Let themers set the text value instead of just using 0. -aj
// todo: Let themers set the text instead of just using 0. -aj
m_textHighScore[pn].SetText( ssprintf("%*i", NUM_SCORE_DIGITS, 0) ); m_textHighScore[pn].SetText( ssprintf("%*i", NUM_SCORE_DIGITS, 0) );
} }
} }
@@ -331,7 +331,6 @@ static BOOL CALLBACK DIMouse_EnumDevObjectsProc(LPCDIDEVICEOBJECTINSTANCE dev, L
in.ofs = dev->dwOfs; in.ofs = dev->dwOfs;
// xxx: does this check for scrollwheels? -aj
if(dev->dwType & DIDFT_BUTTON) if(dev->dwType & DIDFT_BUTTON)
{ {
in.type = in.BUTTON; in.type = in.BUTTON;
+2 -2
View File
@@ -101,7 +101,7 @@ void run()
CHECK( test.GetElapsedTimeFromBeat(15.0f), 14.5f ); // stopped CHECK( test.GetElapsedTimeFromBeat(15.0f), 14.5f ); // stopped
CHECK( test.GetElapsedTimeFromBeat(16), 20.0f ); CHECK( test.GetElapsedTimeFromBeat(16), 20.0f );
/* todo: add warp tests once the warp code is done */ // todo: add warp tests -aj
RageTimer foobar; RageTimer foobar;
/* We can look up the time of any given beat, then look up the beat of that /* We can look up the time of any given beat, then look up the beat of that
@@ -124,10 +124,10 @@ int q = 0;
} }
LOG->Trace("... %i in %f", q, foobar.GetDeltaTime()); LOG->Trace("... %i in %f", q, foobar.GetDeltaTime());
// todo: add warp segments
TimingData test2; TimingData test2;
test2.AddBPMSegment( BPMSegment(0, 60) ); test2.AddBPMSegment( BPMSegment(0, 60) );
test2.AddStopSegment( StopSegment(0, 1) ); test2.AddStopSegment( StopSegment(0, 1) );
//test2.AddWarpSegment( WarpSegment() );
CHECK( test2.GetBeatFromElapsedTime(-1), -1.0f ); CHECK( test2.GetBeatFromElapsedTime(-1), -1.0f );
CHECK( test2.GetBeatFromElapsedTime(0), 0.0f ); CHECK( test2.GetBeatFromElapsedTime(0), 0.0f );
CHECK( test2.GetBeatFromElapsedTime(1), 0.0f ); CHECK( test2.GetBeatFromElapsedTime(1), 0.0f );