cleanup, consolidate indexing by PlayerNumber

stepmania/src/GhostArrowRow.cpp

@@ -76,10 +76,7 @@ void GhostArrowRow::DrawPrimitives()
 {
 	for( unsigned c=0; c<m_Ghost.size(); c++ )
 	{
-		// TODO: Remove indexing by PlayerNumber.
-		PlayerNumber pn = m_pPlayerState->m_PlayerNumber;
-
-		NoteFieldMode::BeginDrawTrack( pn, c );
+		NoteFieldMode::BeginDrawTrack( m_pPlayerState, c );
 		m_Ghost[c]->Draw();
 		NoteFieldMode::EndDrawTrack( c );
 	}

stepmania/src/NoteField.cpp

@@ -670,9 +670,7 @@ void NoteField::DrawPrimitives()
 
 	for( int c=0; c<m_pNoteData->GetNumTracks(); c++ )	// for each arrow column
 	{
-		// TODO: Remove use of PlayerNumber.
-		PlayerNumber pn = m_pPlayerState->m_PlayerNumber;
-		NoteFieldMode::BeginDrawTrack( pn, c );
+		NoteFieldMode::BeginDrawTrack( m_pPlayerState, c );
 
 		//
 		// Draw all HoldNotes in this column (so that they appear under the tap notes)

stepmania/src/NoteFieldPositioning.cpp

@@ -5,8 +5,9 @@
 #include "RageLog.h"
 #include "GameState.h"
 #include "Style.h"
+#include "PlayerState.h"
 
-void NoteFieldMode::BeginDrawTrack( PlayerNumber pn, int iTrack )
+void NoteFieldMode::BeginDrawTrack( const PlayerState* pPlayerState, int iTrack )
 {
 	DISPLAY->CameraPushMatrix();
 
@@ -15,7 +16,8 @@ void NoteFieldMode::BeginDrawTrack( PlayerNumber pn, int iTrack )
 	DISPLAY->PushMatrix();
 
 	const Style *s = GAMESTATE->GetCurrentStyle();
-	const float fPixelXOffsetFromCenter = s->m_ColumnInfo[pn][iTrack].fXOffset;
+	// TODO: Remove indexing by PlayerNumber.
+	float fPixelXOffsetFromCenter = s->m_ColumnInfo[pPlayerState->m_PlayerNumber][iTrack].fXOffset;
 	DISPLAY->Translate( fPixelXOffsetFromCenter, 0, 0 );
 }
 

stepmania/src/NoteFieldPositioning.h

@@ -3,9 +3,10 @@
 
 #include "PlayerNumber.h"
 
+class PlayerState;
 namespace NoteFieldMode
 {
-	void BeginDrawTrack( PlayerNumber pn, int iTrack );
+	void BeginDrawTrack( const PlayerState* pPlayerState, int iTrack );
 	void EndDrawTrack( int iTrack );
 };
 

stepmania/src/Player.cpp

@@ -857,12 +857,9 @@ void Player::DrawHoldJudgments()
 	if( m_pPlayerState->m_PlayerOptions.m_fBlind > 0 )
 		return;
 
-	// TODO: Remove use of PlayerNumber.
-	PlayerNumber pn = m_pPlayerState->m_PlayerNumber;
-
 	for( int c=0; c<m_NoteData.GetNumTracks(); c++ )
 	{
-		NoteFieldMode::BeginDrawTrack( pn, c );
+		NoteFieldMode::BeginDrawTrack( m_pPlayerState, c );
 
 		m_vHoldJudgment[c]->Draw();