Set comment as output

Move the logic from the caller as a negation instead of trying to
negate it by hand.

.github/workflows/stale.yaml

@@ -1,6 +1,7 @@
-name: Close stale PRs
+name: Close stale PRs and Issues
 
 permissions:
+  issues: write
   pull-requests: write
 
 on:
@@ -12,14 +13,14 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/stale@v9.0.0
-      name: Clean up stale PRs
+      name: Clean up stale PRs and Issues
       with:
         stale-pr-message: "👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the `Keep` label to hold stale off permanently, or do nothing. If you do nothing, this pull request will be closed eventually by the stale bot. Please see CONTRIBUTING.md for more policy details."
         stale-pr-label: "Stale"
         exempt-pr-labels: "Keep" # a "Keep" label will keep the PR from being closed as stale
         days-before-pr-stale: 180 # when the PR is considered stale
         days-before-pr-close: 15 # when the PR is closed by the bot, 
-        days-before-issue-stale: -1 # prevents issues from being tagged by the bot
-        days-before-issue-close: -1 # prevents issues from being closed by the bot
+        days-before-issue-stale: 180 # prevents issues from being tagged by the bot
+        days-before-issue-close: 15 # prevents issues from being closed by the bot
         exempt-assignees: 'advanced-security-dependency-graph'
         ascending: true

dist/index.js

@@ -60,9 +60,9 @@ function commentPr(summary, config) {
     return __awaiter(this, void 0, void 0, function* () {
         const commentContent = summary.stringify();
         core.setOutput('comment-content', commentContent);
-        if (config.comment_summary_in_pr !== 'always' &&
-            config.comment_summary_in_pr === 'on-failure' &&
-            process.exitCode !== core.ExitCode.Failure) {
+        if (!(config.comment_summary_in_pr === 'always' ||
+            (config.comment_summary_in_pr === 'on-failure' &&
+                process.exitCode === core.ExitCode.Failure))) {
             return;
         }
         if (!github.context.payload.pull_request) {

docs/examples.md

@@ -189,7 +189,8 @@ jobs:
           fail-on-severity: critical
           deny-licenses: LGPL-2.0, BSD-2-Clause
       - name: 'Report'
-        if: always()  # make sure this step runs even if the previous failed
+        # make sure this step runs even if the previous failed
+        if: ${{ failure() && steps.review.conclusion == 'failure' }}
         shell: bash
         env:
           comment: ${{ steps.review.outputs.comment-content }}

package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "dependency-review-action",
-  "version": "4.1.1",
+  "version": "4.1.3",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "dependency-review-action",
-      "version": "4.1.1",
+      "version": "4.1.3",
       "license": "MIT",
       "dependencies": {
         "@actions/core": "^1.10.1",

package.json

@@ -1,6 +1,6 @@
 {
   "name": "dependency-review-action",
-  "version": "4.1.1",
+  "version": "4.1.3",
   "private": true,
   "description": "A GitHub Action for Dependency Review",
   "main": "lib/main.js",

src/comment-pr.ts

@@ -22,9 +22,11 @@ export async function commentPr(
   core.setOutput('comment-content', commentContent)
 
   if (
-    config.comment_summary_in_pr !== 'always' &&
-    config.comment_summary_in_pr === 'on-failure' &&
-    process.exitCode !== core.ExitCode.Failure
+    !(
+      config.comment_summary_in_pr === 'always' ||
+      (config.comment_summary_in_pr === 'on-failure' &&
+        process.exitCode === core.ExitCode.Failure)
+    )
   ) {
     return
   }