Refactor: improve full scan manifest test

This commit is contained in:
Lewis Jones
2025-07-09 13:46:43 +01:00
parent 0b0b651777
commit e6ad22924a
+3 -23
View File
@@ -221,7 +221,6 @@ test('full action scan creates manifests with correct names and file source loca
expect(manifests).toBeDefined();
expect(manifests!.length).toBeGreaterThan(0);
// Ensure no manifest names have leading slashes
for (const manifest of manifests!) {
expect(manifest.name.startsWith('/')).toBe(false);
}
@@ -234,34 +233,15 @@ test('full action scan creates manifests with correct names and file source loca
'environment.yaml'
];
// Create a lookup for manifests by name
const manifestsByName = manifests!.reduce((acc, manifest) => {
acc[manifest.name] = manifest;
return acc;
}, {} as Record<string, any>);
// Check each expected manifest if it exists
for (const expectedName of expectedManifestNames) {
const manifest = manifestsByName[expectedName];
if (manifest) {
expect(manifest.name).toBe(expectedName);
expect(manifest.file?.source_location).toBe(expectedName);
}
}
// Verify specific expected manifests exist with correct properties
if (manifestsByName['package.json']) {
expect(manifestsByName['package.json'].name).toBe('package.json');
expect(manifestsByName['package.json'].file?.source_location).toBe('package.json');
}
if (manifestsByName['nested/package.json']) {
expect(manifestsByName['nested/package.json'].name).toBe('nested/package.json');
expect(manifestsByName['nested/package.json'].file?.source_location).toBe('nested/package.json');
}
if (manifestsByName['environment.yaml']) {
expect(manifestsByName['environment.yaml'].name).toBe('environment.yaml');
expect(manifestsByName['environment.yaml'].file?.source_location).toBe('environment.yaml');
expect(manifest).toBeDefined();
expect(manifest.name).toBe(expectedName);
expect(manifest.file?.source_location).toBe(expectedName);
}
}, 15000);