Commit Graph
2 Commits
Author SHA1 Message Date
01c8dc237e Fix example manifests for webhooks-based scaling (#1354)
* Fix example manifests for webhook based scaling

I tried running these on my k8s cluster and I got some easy to fix errors, so I am committing them here.

* Fix example manifests for webhook autoscaling with workflow_jobs

* Fix the explation on how to setup webhooks on your cluster

* Replace unclear comment with actual code examples

There was a comment instructing users to add minReplicas and
maxReplicas to all the HRA yamls, so I just removed it and added
these attributes to the yamls themselves for clarity.

* Make clear that using the ingress example is just a suggestion

* Apply some text improvements suggested by @mumoshu

* Update examples so the webhook server is exposed on a NodePort

Co-authored-by: Yusuke Kuoka <[email protected]>

* Remove an unnecessary field from one the examples

Co-authored-by: Yusuke Kuoka <[email protected]>

* Apply suggestion from @mumoshu

Co-authored-by: Yusuke Kuoka <[email protected]>

* Remove namespace fields from webhook autoscaler examples

This change was suggested by @mumoshu

* Apply final suggestion from @mumoshu

Co-authored-by: Callum Tait <[email protected]>
Co-authored-by: Yusuke Kuoka <[email protected]>
2022-06-07 08:33:09 +09:00
9f254a2393 docs: run README files through Grammarly (#1353)
* Update README.md

* Run charts/actions-runner-controller/README.md thorugh Grammarly

* Fix broken link as suggested by @toast-gear

Co-authored-by: Callum Tait <[email protected]>

Co-authored-by: Callum Tait <[email protected]>
2022-04-22 16:58:10 +01:00