From d2e5a6251090a7a85516dceb12180ce32f52c283 Mon Sep 17 00:00:00 2001
From: S <islam.ahmad@outlook.com>
Date: Sun, 1 Mar 2026 10:39:38 -0500
Subject: [PATCH] fix: resolve shellcheck warnings (SC2168, SC2089, SC2090,
 SC2016, SC2329)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 phase1_gitea_unraid.sh     | 2 ++
 phase2_gitea_fedora.sh     | 2 ++
 preflight.sh               | 1 +
 setup/configure_runners.sh | 1 -
 4 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/phase1_gitea_unraid.sh b/phase1_gitea_unraid.sh
index f569801..1e46673 100755
--- a/phase1_gitea_unraid.sh
+++ b/phase1_gitea_unraid.sh
@@ -57,10 +57,12 @@ _set_db_vars() {
       DB_DOCKER_IMAGE="mcr.microsoft.com/mssql/server:2022-latest"
       DB_ENV_VARS="      - ACCEPT_EULA=Y
       - SA_PASSWORD=${GITEA_DB_PASSWD}"
+      # shellcheck disable=SC2089,SC2016
       DB_HEALTHCHECK='["CMD-SHELL", "/opt/mssql-tools18/bin/sqlcmd -S localhost -U sa -P '"'"'${GITEA_DB_PASSWD}'"'"' -Q \"SELECT 1\" -C -N"]'
       DB_DATA_DIR="mssql/data"
       ;;
   esac
+  # shellcheck disable=SC2090
   export DB_DOCKER_IMAGE DB_ENV_VARS DB_HEALTHCHECK DB_DATA_DIR
 }
 
diff --git a/phase2_gitea_fedora.sh b/phase2_gitea_fedora.sh
index 7ddb90f..7e75876 100755
--- a/phase2_gitea_fedora.sh
+++ b/phase2_gitea_fedora.sh
@@ -53,10 +53,12 @@ _set_db_vars() {
       DB_DOCKER_IMAGE="mcr.microsoft.com/mssql/server:2022-latest"
       DB_ENV_VARS="      - ACCEPT_EULA=Y
       - SA_PASSWORD=${GITEA_DB_PASSWD}"
+      # shellcheck disable=SC2089,SC2016
       DB_HEALTHCHECK='["CMD-SHELL", "/opt/mssql-tools18/bin/sqlcmd -S localhost -U sa -P '"'"'${GITEA_DB_PASSWD}'"'"' -Q \"SELECT 1\" -C -N"]'
       DB_DATA_DIR="mssql/data"
       ;;
   esac
+  # shellcheck disable=SC2090
   export DB_DOCKER_IMAGE DB_ENV_VARS DB_HEALTHCHECK DB_DATA_DIR
 }
 
diff --git a/preflight.sh b/preflight.sh
index d49358c..bc32201 100755
--- a/preflight.sh
+++ b/preflight.sh
@@ -399,6 +399,7 @@ fi
 if [[ "$SKIP_PORT_CHECKS" == "true" ]]; then
   log_info "[13] Container IP availability — SKIPPED (--skip-port-checks)"
 else
+  # shellcheck disable=SC2329
   check_ips_available() {
     local fail=0
     for ip_var in UNRAID_GITEA_IP UNRAID_CADDY_IP FEDORA_GITEA_IP FEDORA_CADDY_IP; do
diff --git a/setup/configure_runners.sh b/setup/configure_runners.sh
index 7074e18..2f8227e 100755
--- a/setup/configure_runners.sh
+++ b/setup/configure_runners.sh
@@ -447,7 +447,6 @@ for ((i = 0; i < runner_count; i++)); do
   if [[ -z "$repos_default" ]]; then repos_default="all"; fi
   # Build hint with known repo names
   repos_hint="token scope: all"
-  local _rn
   for _rn in ${REPO_NAMES:-}; do
     repos_hint="${repos_hint}, ${_rn}"
   done