privacy-in-design/gitea-migration
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: fix shellcheck findings across migration scripts

Browse Source
This commit is contained in:
S
2026-02-28 21:39:23 -05:00
parent 572e4c151c
commit 743f1281e6
23 changed files with 68 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
preflight.sh
View File

@@ -1,5 +1,6 @@
#!/usr/bin/env bash
set -euo pipefail
# shellcheck disable=SC2329
# =============================================================================
# preflight.sh — Validate everything before running migration phases
@@ -75,6 +76,7 @@ check_fedora_os() {
# ---------------------------------------------------------------------------
# Check 4: .env exists
# ---------------------------------------------------------------------------
# shellcheck disable=SC2329
check_env_exists() {
[[ -f "${SCRIPT_DIR}/.env" ]]
}
@@ -88,6 +90,7 @@ fi
# ---------------------------------------------------------------------------
# Check 5: runners.conf exists
# ---------------------------------------------------------------------------
# shellcheck disable=SC2329
check_runners_conf() {
[[ -f "${SCRIPT_DIR}/runners.conf" ]]
}
@@ -119,6 +122,7 @@ REQUIRED_VARS=(
NGINX_CONTAINER_NAME NGINX_CONF_PATH SSL_MODE
)
# shellcheck disable=SC2329
check_required_vars() {
local missing=0
for var in "${REQUIRED_VARS[@]}"; do
@@ -154,13 +158,14 @@ check_required_vars() {
;;
esac
return $missing
return "$missing"
}
check 6 "All required .env vars are set" check_required_vars
# ---------------------------------------------------------------------------
# Check 7: SSH to Unraid
# ---------------------------------------------------------------------------
# shellcheck disable=SC2329
check_ssh_unraid() {
ssh_check UNRAID
}
@@ -172,6 +177,7 @@ fi
# ---------------------------------------------------------------------------
# Check 8: SSH to Fedora
# ---------------------------------------------------------------------------
# shellcheck disable=SC2329
check_ssh_fedora() {
ssh_check FEDORA
}
@@ -298,6 +304,7 @@ fi
# ---------------------------------------------------------------------------
# Check 17: GitHub repos exist
# ---------------------------------------------------------------------------
# shellcheck disable=SC2329
check_github_repos() {
local all_ok=0
for var in REPO_1_NAME REPO_2_NAME REPO_3_NAME; do
@@ -310,7 +317,7 @@ check_github_repos() {
all_ok=1
fi
done
return $all_ok
return "$all_ok"
}
check 17 "All GitHub repos exist" check_github_repos
@@ -342,36 +349,39 @@ fi
# Check 20: Local tool minimum versions
# Validates that tools on the MacBook meet minimum requirements.
# ---------------------------------------------------------------------------
# shellcheck disable=SC2329
check_local_versions() {
local fail=0
check_min_version "jq" "jq --version" "1.6" || fail=1
check_min_version "curl" "curl --version" "7.70" || fail=1
check_min_version "git" "git --version" "2.30" || fail=1
return $fail
return "$fail"
}
check 20 "Local tool minimum versions (jq>=1.6, curl>=7.70, git>=2.30)" check_local_versions
# ---------------------------------------------------------------------------
# Check 21: Unraid tool minimum versions
# ---------------------------------------------------------------------------
# shellcheck disable=SC2329
check_unraid_versions() {
local fail=0
check_remote_min_version "UNRAID" "docker" "docker --version" "20.0" || fail=1
check_remote_min_version "UNRAID" "docker-compose" "docker compose version 2>/dev/null || docker-compose --version" "2.0" || fail=1
check_remote_min_version "UNRAID" "jq" "jq --version" "1.6" || fail=1
return $fail
return "$fail"
}
check 21 "Unraid tool minimum versions (docker>=20, compose>=2, jq>=1.6)" check_unraid_versions
# ---------------------------------------------------------------------------
# Check 22: Fedora tool minimum versions
# ---------------------------------------------------------------------------
# shellcheck disable=SC2329
check_fedora_versions() {
local fail=0
check_remote_min_version "FEDORA" "docker" "docker --version" "20.0" || fail=1
check_remote_min_version "FEDORA" "docker-compose" "docker compose version" "2.0" || fail=1
check_remote_min_version "FEDORA" "jq" "jq --version" "1.6" || fail=1
return $fail
return "$fail"
}
check 22 "Fedora tool minimum versions (docker>=20, compose>=2, jq>=1.6)" check_fedora_versions