Austen Stone
cbc06d6766
fix: ensure max artifact count variable is treated as a string
2025-10-22 07:47:51 -04:00
Austen Stone
9bb6708527
fix: remove redundant check for max artifact count variable
2025-10-22 07:41:31 -04:00
Austen Stone
be1151df02
Apply suggestion from @Link-
...
Co-authored-by: Bassem Dghaidi <568794+Link-@users.noreply.github.com >
2025-10-22 07:39:45 -04:00
Austen Stone
fea4f6b5c5
fix: resolve critical pagination bugs and add comprehensive testing
...
- Fix off-by-one error in pagination loop (< to <=) that prevented fetching last page
- Add Math.ceil() to maxNumberOfPages calculation for proper limit handling
- Replace hardcoded 2000 limit with configurable getMaxArtifactListCount()
- Add pagination test for multi-page artifact listing
- Add environment variable test for ACTIONS_ARTIFACT_MAX_ARTIFACT_COUNT
- Add comprehensive test coverage for getMaxArtifactListCount() function
Fixes compound bug where pagination and limit logic capped results at 900 artifacts instead of intended 1000.
2025-10-21 09:22:11 -04:00
Salman Chishti
2559a2ac8a
Merge pull request #1982 from actions/salmanmkc/obfuscate-sas
...
Remove logging of any SAS tokens in Actions/Cache and Actions/Artifact
2025-03-17 11:47:29 +00:00
Salman Chishti
957d42e6c5
add encoding back with extra tests
2025-03-14 06:38:57 -07:00
Salman Chishti
39419dd8c3
don't need to url encode or set var
2025-03-14 06:21:41 -07:00
Salman Chishti
6876e2a664
update ts docs
2025-03-13 04:47:49 -07:00
Salman Chishti
fc482662af
PR feedback, back to simplified approach, no export on client as well
2025-03-13 04:23:45 -07:00
Salman Chishti
3ac34ffcb7
Mask different situations, malformed URL, encoded, decoded, raw signatures, nested parameters, and moved to a utility file
2025-03-12 03:17:35 -07:00
Ryan Ghadimi
d7ddca4309
Fix comment on expectedHash
2025-03-11 10:52:19 +00:00
Salman Chishti
47c4fa85df
masks the whole URL, update tests
2025-03-10 06:47:52 -07:00
Salman Chishti
1cd2f8a538
Instead of using utility method in core lib, use method in both twirp clients
2025-03-07 06:01:25 -08:00
Salman Chishti
944e6b78db
Add secret and signature masking for cache and artifact packages
2025-03-06 14:25:32 -08:00
Ryan Ghadimi
d5c8a0fa27
Update proto artifact interface, retrieve artifact digests, return indicator of mismatch failure
2025-03-05 11:29:44 +00:00
Yang Cao
c26e6f3aba
Default upload artifacts concurrency to 5
2025-02-20 17:03:29 +00:00
Yang Cao
e55409315f
Rename the prefix to be more specific
2025-01-08 20:32:45 +00:00
Yang Cao
d4385a64a7
Concurrency has a min of 1
2025-01-08 18:14:04 +00:00
Yang Cao
ede05b95d7
Make concurrency change opt-in, but can only go lower
2025-01-08 18:11:38 +00:00
Yang Cao
f3c12d5561
Set default concurrency to 10 and make timeout configurable
2025-01-08 16:19:09 +00:00
Brian DeHamer
1e0c16f0dc
return artifact digest on upload
...
Signed-off-by: Brian DeHamer <bdehamer@github.com >
2024-12-06 14:27:46 -08:00
Sébastien Morais
3a33cca851
FIX: Set chunk timeout back to 5 minutes
2024-08-06 10:27:41 +02:00
Rob Herley
3e34f6d19c
add comment for chunk timeout
2024-07-24 12:40:57 -04:00
Rob Herley
182702d2df
fix chunk timeout + update tests
2024-07-23 21:57:39 -04:00
Rob Herley
176b40a888
allow localhost hostnames for artifact checks
2024-07-03 16:55:53 +00:00
Rob Herley
ccb1df45d1
artifact client: retry on non-JSON response
2024-04-19 14:03:47 +00:00
eggyhead
d134334a38
lint fixes
2024-01-31 16:51:04 +00:00
eggyhead
3b02a6fdc5
updating alowed hosts in isGhes check
...
updating alowed hosts in artifact ghes check
using dot prepend ghe host
2024-01-31 16:30:37 +00:00
Rob Herley
b62d4c91b6
add public and internal methods to delete artifacts
2024-01-17 16:18:49 -05:00
Rob Herley
16b786a545
better error message for usage limits
2023-12-11 22:01:08 -05:00
Rob Herley
a4bd0f1214
Add specific messages for network-specific node error codes
2023-12-11 17:07:48 -05:00
Vallie Joseph
950e1711a1
Improve error messages (duplicate artifacts; too many artifacts) ( #1600 )
...
* cleaning up error messages
* updating package-json
* updating package-lock
* .
* .
* testing return message
* updating error check
* adding test
* rmv unused var
* updating status code to match conflict message
2023-12-11 11:26:54 -05:00
Jonathan Tamsut
88b76de595
Add back 429 to list of retryable requests ( #1599 )
...
* add back 429 to list of retryable requests
* fix lint error
2023-12-08 11:00:44 -08:00
Jonathan Tamsut
55a05255d7
Remove 429 request from list of retry-able status codes ( #1597 )
...
* remove 429 request from retryable
* remove 413
* make linter happy
2023-12-07 13:22:17 -08:00
Rob Herley
64d1b104d0
Generate Typescript Docs for @actions/artifact ( #1595 )
...
* autogenerate artifact documentation
* clean up comments for better autogen docs
2023-12-07 09:57:20 -08:00
Rob Herley
f732e4cd62
linter
2023-12-06 23:57:33 +00:00
Rob Herley
8c317a0e59
one too many parses
2023-12-06 23:51:16 +00:00
Rob Herley
715b1acc05
cleanup artifact handlers hanging node process
2023-12-06 23:42:07 +00:00
Rob Herley
befa19f3a8
initalize artifact client as default export
2023-12-06 04:00:07 +00:00
Rob Herley
e27efe5620
readme & error updates
2023-12-05 21:55:22 +00:00
Rob Herley
a3053b5cc2
fix typo
2023-12-05 18:47:37 +00:00
Rob Herley
b9872153b8
update GHES warning behavior
2023-12-05 18:42:36 +00:00
Rob Herley
ce9eae0785
consistent promise behavior for download artifact
2023-12-05 18:35:26 +00:00
Rob Herley
d3c5f358d1
consistent promise behavior for get artifact
2023-12-05 17:56:18 +00:00
Rob Herley
75a3586061
consistent promise behavior for upload artifact
2023-12-05 17:35:46 +00:00
Rob Herley
c11a7cdeac
wip
2023-12-03 06:24:49 +00:00
Rob Herley
c94ca49c9c
ability to filter artifacts by latest
2023-12-03 05:01:20 +00:00
Rob Herley
c1f9d37323
updates to get/list artifacts
2023-12-02 21:18:22 -05:00
Rob Herley
57db7a6302
more debug info
2023-12-01 03:04:10 +00:00
Rob Herley
4789a46578
make FindOptions interface more user friendly
2023-12-01 02:15:25 +00:00