Salman Muin Kayser Chishti
8a2701f328
fix(cache): replace @azure/ms-rest-js with @azure/core-rest-pipeline
...
Remove abandoned @azure/ms-rest-js dependency which pulls in node-fetch@v2, causing punycode deprecation warnings on Node.js 24+.
The TransferProgressEvent type is now imported from @azure/core-rest-pipeline instead.
2025-12-10 11:23:06 +00:00
Ryan Ghadimi
06f7fd9df1
new error state, tests to cover
2025-08-13 13:00:46 +00:00
Ryan Ghadimi
0fe20e9d56
remove cache size limit
2025-08-13 10:14:18 +00:00
Bassem Dghaidi
6d3feab2bf
Merge pull request #2100 from actions/copilot/fix-2099
...
Improve cache service availability determination and implement conditional error logging
2025-07-28 16:49:10 +02:00
copilot-swe-agent[bot]
bd54a2413a
Fix v1 cache service to only check ACTIONS_CACHE_URL
...
Co-authored-by: Link- <568794+Link-@users.noreply.github.com >
2025-07-14 13:39:13 +00:00
copilot-swe-agent[bot]
d48d6b62a4
Remove logCacheError function and implement inline 5xx error detection as requested
...
Co-authored-by: Link- <568794+Link-@users.noreply.github.com >
2025-07-14 12:42:37 +00:00
copilot-swe-agent[bot]
c51178a15e
Implement 5xx server error detection and fix most cache tests
...
Co-authored-by: Link- <568794+Link-@users.noreply.github.com >
2025-07-14 12:23:44 +00:00
copilot-swe-agent[bot]
cf3aaeb491
Update tests to expect warnings instead of errors for non-5xx cache failures
...
Co-authored-by: Link- <568794+Link-@users.noreply.github.com >
2025-07-14 12:07:37 +00:00
Bassem Dghaidi
cf4886cccb
Fix linting issues
2025-07-14 03:49:28 -07:00
Bassem Dghaidi
0c5da92b52
Fix logging of cache key and restore key matches
2025-07-14 03:45:17 -07:00
copilot-swe-agent[bot]
3c90578c30
Improve cache service availability determination and change warnings to errors
...
- Update isFeatureAvailable() to leverage ACTIONS_CACHE_SERVICE_V2 feature flag
- For v2: check ACTIONS_RESULTS_URL availability
- For v1: check either ACTIONS_CACHE_URL or ACTIONS_RESULTS_URL availability
- Change warning logs to error logs for cache failures
- Add comprehensive tests covering all scenarios
Co-authored-by: Link- <568794+Link-@users.noreply.github.com >
2025-07-14 10:32:34 +00:00
JoannaaKL
857c61a9df
Merge pull request #1994 from gitulisca-enterprise-cloud-testing/gitulisca/log-restore-request-version
...
Log cache version requested on debugging message
2025-03-17 17:58:16 +01:00
Art Leo
514314311c
Log cache version requested
2025-03-15 10:13:43 +11:00
Salman Chishti
957d42e6c5
add encoding back with extra tests
2025-03-14 06:38:57 -07:00
Salman Chishti
39419dd8c3
don't need to url encode or set var
2025-03-14 06:21:41 -07:00
Salman Chishti
6876e2a664
update ts docs
2025-03-13 04:47:49 -07:00
Salman Chishti
fc482662af
PR feedback, back to simplified approach, no export on client as well
2025-03-13 04:23:45 -07:00
Salman Chishti
abd9054c61
Log debug error when failing to decode
2025-03-12 08:14:01 -07:00
Salman Chishti
3ac34ffcb7
Mask different situations, malformed URL, encoded, decoded, raw signatures, nested parameters, and moved to a utility file
2025-03-12 03:17:35 -07:00
Salman Chishti
47c4fa85df
masks the whole URL, update tests
2025-03-10 06:47:52 -07:00
Salman Chishti
1cd2f8a538
Instead of using utility method in core lib, use method in both twirp clients
2025-03-07 06:01:25 -08:00
Salman Chishti
944e6b78db
Add secret and signature masking for cache and artifact packages
2025-03-06 14:25:32 -08:00
Rob Herley
d096588f08
cache: wrap create failures in ReserveCacheError
2025-02-25 12:49:08 -05:00
Rob Herley
e6fb8f1c5d
cache miss as debug, not warning annotation
2025-02-14 09:28:01 -05:00
Rob Herley
e0c069db55
remove runtime dependency on twirp-ts
2025-01-27 17:52:55 +00:00
Josh Gross
01f21badd5
Remove more unused cache APIs
2024-12-17 14:51:57 -05:00
Josh Gross
26f8f84a96
Remove unused cache API ( #1907 )
2024-12-17 14:04:05 -05:00
Bassem Dghaidi
c02c929c56
Minor comment adjustments
2024-12-02 11:10:25 -08:00
Bassem Dghaidi
c649df4b94
Minor comment adjustments
2024-12-02 10:55:33 -08:00
Bassem Dghaidi
fb40492b6f
Merge branch 'enhance-blob-client' of github.com:actions/toolkit into enhance-blob-client
2024-12-02 10:55:00 -08:00
Bassem Dghaidi
502e8ce651
Minor comment adjustments
2024-12-02 10:53:29 -08:00
Bassem Dghaidi
3f7df8ec5a
Fix comments
...
Co-authored-by: Josh Gross <joshmgross@github.com >
2024-12-02 19:46:18 +01:00
Bassem Dghaidi
b24632bd80
Fix comments
...
Co-authored-by: Josh Gross <joshmgross@github.com >
2024-12-02 19:46:11 +01:00
Bassem Dghaidi
792ec716de
Tune upload options
2024-12-02 07:32:33 -08:00
Bassem Dghaidi
a762876d6d
Minor refactoring
2024-12-02 04:08:21 -08:00
Bassem Dghaidi
d89855bb90
Fix upload progress bug
2024-12-02 03:55:57 -08:00
Bassem Dghaidi
db1d01308c
Troubleshoot
2024-12-02 03:35:20 -08:00
Bassem Dghaidi
4a272e9053
Troubleshoot
2024-12-02 03:08:05 -08:00
Bassem Dghaidi
ee1c07d0aa
Add error handling for failed uploads
2024-12-02 02:38:51 -08:00
Bassem Dghaidi
c6f1224d30
Add progress tracking for blob uploads
2024-12-02 02:33:27 -08:00
Bassem Dghaidi
1d403c2fd8
Fix tests
2024-11-29 07:36:51 -08:00
Bassem Dghaidi
65892d5ffe
Fine tune blob uploads
2024-11-29 07:09:05 -08:00
Bassem Dghaidi
8c5f6f2dc5
Force use of Azure for restoreCacheV2
2024-11-28 07:42:07 -08:00
Bassem Dghaidi
62f5f1885b
Refactor saveCacheV2 to use saveCache from cacheHttpClient
2024-11-28 07:22:01 -08:00
Bassem Dghaidi
eaf0083ee2
Respect download options for restore
2024-11-28 04:56:37 -08:00
Bassem Dghaidi
c1fb081674
Linter fixes
2024-11-28 03:53:34 -08:00
Bassem Dghaidi
df166709a3
Refactor cache upload functionality and improve test cases
2024-11-28 03:52:09 -08:00
Bassem Dghaidi
c5a5de05f6
Delete download-cache
2024-11-28 03:36:32 -08:00
Bassem Dghaidi
35d87ab129
Refactor code formatting for consistency and readability
2024-11-27 05:58:22 -08:00
Bassem Dghaidi
af3981c955
Update the useragent of the old http client to pass cache version
2024-11-27 05:50:01 -08:00