Update tests to expect warnings instead of errors for non-5xx cache failures

Co-authored-by: Link- <568794+Link-@users.noreply.github.com>

packages/cache/__tests__/saveCache.test.ts

@@ -50,7 +50,7 @@ test('save with large cache outputs should fail', async () => {
   const cachePaths = [path.resolve(filePath)]
 
   const createTarMock = jest.spyOn(tar, 'createTar')
-  const logErrorMock = jest.spyOn(core, 'error')
+  const logWarningMock = jest.spyOn(core, 'warning')
 
   const cacheSize = 11 * 1024 * 1024 * 1024 //~11GB, over the 10GB limit
   jest
@@ -63,8 +63,8 @@ test('save with large cache outputs should fail', async () => {
 
   const cacheId = await saveCache([filePath], primaryKey)
   expect(cacheId).toBe(-1)
-  expect(logErrorMock).toHaveBeenCalledTimes(1)
-  expect(logErrorMock).toHaveBeenCalledWith(
+  expect(logWarningMock).toHaveBeenCalledTimes(1)
+  expect(logWarningMock).toHaveBeenCalledWith(
     'Failed to save: Cache size of ~11264 MB (11811160064 B) is over the 10GB limit, not saving cache.'
   )
 
@@ -85,7 +85,7 @@ test('save with large cache outputs should fail in GHES with error message', asy
   const cachePaths = [path.resolve(filePath)]
 
   const createTarMock = jest.spyOn(tar, 'createTar')
-  const logErrorMock = jest.spyOn(core, 'error')
+  const logWarningMock = jest.spyOn(core, 'warning')
 
   const cacheSize = 11 * 1024 * 1024 * 1024 //~11GB, over the 10GB limit
   jest
@@ -115,8 +115,8 @@ test('save with large cache outputs should fail in GHES with error message', asy
 
   const cacheId = await saveCache([filePath], primaryKey)
   expect(cacheId).toBe(-1)
-  expect(logErrorMock).toHaveBeenCalledTimes(1)
-  expect(logErrorMock).toHaveBeenCalledWith(
+  expect(logWarningMock).toHaveBeenCalledTimes(1)
+  expect(logWarningMock).toHaveBeenCalledWith(
     'Failed to save: The cache filesize must be between 0 and 1073741824 bytes'
   )
 
@@ -137,7 +137,7 @@ test('save with large cache outputs should fail in GHES without error message',
   const cachePaths = [path.resolve(filePath)]
 
   const createTarMock = jest.spyOn(tar, 'createTar')
-  const logErrorMock = jest.spyOn(core, 'error')
+  const logWarningMock = jest.spyOn(core, 'warning')
 
   const cacheSize = 11 * 1024 * 1024 * 1024 //~11GB, over the 10GB limit
   jest
@@ -163,8 +163,8 @@ test('save with large cache outputs should fail in GHES without error message',
 
   const cacheId = await saveCache([filePath], primaryKey)
   expect(cacheId).toBe(-1)
-  expect(logErrorMock).toHaveBeenCalledTimes(1)
-  expect(logErrorMock).toHaveBeenCalledWith(
+  expect(logWarningMock).toHaveBeenCalledTimes(1)
+  expect(logWarningMock).toHaveBeenCalledWith(
     'Failed to save: Cache size of ~11264 MB (11811160064 B) is over the data cap limit, not saving cache.'
   )
 

packages/cache/__tests__/saveCacheV2.test.ts

@@ -65,7 +65,7 @@ test('save with large cache outputs should fail using', async () => {
   const cachePaths = [path.resolve(paths)]
 
   const createTarMock = jest.spyOn(tar, 'createTar')
-  const logErrorMock = jest.spyOn(core, 'error')
+  const logWarningMock = jest.spyOn(core, 'warning')
 
   const cacheSize = 11 * 1024 * 1024 * 1024 //~11GB, over the 10GB limit
   jest
@@ -78,7 +78,7 @@ test('save with large cache outputs should fail using', async () => {
 
   const cacheId = await saveCache([paths], key)
   expect(cacheId).toBe(-1)
-  expect(logErrorMock).toHaveBeenCalledWith(
+  expect(logWarningMock).toHaveBeenCalledWith(
     'Failed to save: Cache size of ~11264 MB (11811160064 B) is over the 10GB limit, not saving cache.'
   )
 
@@ -227,7 +227,7 @@ test('finalize save cache failure', async () => {
   const paths = 'node_modules'
   const key = 'Linux-node-bb828da54c148048dd17899ba9fda624811cfb43'
   const cachePaths = [path.resolve(paths)]
-  const logErrorMock = jest.spyOn(core, 'error')
+  const logWarningMock = jest.spyOn(core, 'warning')
   const signedUploadURL = 'https://blob-storage.local?signed=true'
   const archiveFileSize = 1024
   const options: UploadOptions = {
@@ -292,7 +292,7 @@ test('finalize save cache failure', async () => {
   })
 
   expect(cacheId).toBe(-1)
-  expect(logErrorMock).toHaveBeenCalledWith(
+  expect(logWarningMock).toHaveBeenCalledWith(
     `Failed to save: Unable to finalize cache with key ${key}, another job may be finalizing this cache.`
   )
 })