actions/toolkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Simplify constructor by handling undefined in helper method

Browse Source 
Co-authored-by: TingluoHuang <[email protected]>
This commit is contained in:
copilot-swe-agent[bot]
2026-01-06 18:03:26 +00:00
co-authored by TingluoHuang
parent 48a7cdbf9c
commit 97f5a6f0dc
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/http-client/src/index.ts
+7 -4
View File
@@ -147,9 +147,7 @@ export class HttpClient {
handlers?: ifm.RequestHandler[], handlers?: ifm.RequestHandler[],
requestOptions?: ifm.RequestOptions requestOptions?: ifm.RequestOptions
) { ) {
this.userAgent = userAgent this.userAgent = this._getUserAgentWithOrchestrationId(userAgent)
? this._getUserAgentWithOrchestrationId(userAgent)
: undefined
this.handlers = handlers || [] this.handlers = handlers || []
this.requestOptions = requestOptions this.requestOptions = requestOptions
if (requestOptions) { if (requestOptions) {
@@ -818,7 +816,12 @@ export class HttpClient {
return proxyAgent return proxyAgent
} }
private _getUserAgentWithOrchestrationId(userAgent: string): string { private _getUserAgentWithOrchestrationId(
userAgent?: string
): string | undefined {
if (!userAgent) {
return undefined
}
const orchId = process.env['ACTIONS_ORCHESTRATION_ID'] const orchId = process.env['ACTIONS_ORCHESTRATION_ID']
if (orchId) { if (orchId) {
// Sanitize the orchestration ID to ensure it contains only valid characters // Sanitize the orchestration ID to ensure it contains only valid characters