From 0380590fdd9cc05882974277c52b8647873fb676 Mon Sep 17 00:00:00 2001 From: Meredith Lancaster Date: Tue, 9 Dec 2025 08:02:38 -0800 Subject: [PATCH] fix expected endpoint response Signed-off-by: Meredith Lancaster --- packages/attest/__tests__/artifactMetadata.test.ts | 10 +++++----- packages/attest/src/artifactMetadata.ts | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/attest/__tests__/artifactMetadata.test.ts b/packages/attest/__tests__/artifactMetadata.test.ts index 051ea314..0b578945 100644 --- a/packages/attest/__tests__/artifactMetadata.test.ts +++ b/packages/attest/__tests__/artifactMetadata.test.ts @@ -48,13 +48,13 @@ describe('createStorageRecord', () => { registry_url: 'https://my-registry.org' }) }) - .reply(201, {storage_records: [{id: '123'}, {id: '456'}]}) + .reply(200, {storage_records: [{id: 123}, {id: 456}]}) }) it('persists the storage record', async () => { await expect(createStorageRecord(options)).resolves.toEqual([ - '123', - '456' + 123, + 456 ]) }) }) @@ -114,7 +114,7 @@ describe('createStorageRecord', () => { registry_url: options.packageRegistryOptions.registryUrl }) }) - .reply(201, {storage_records: [{id: '123'}, {id: '456'}]}) + .reply(200, {storage_records: [{id: 123}, {id: 456}]}) .times(1) }) @@ -124,7 +124,7 @@ describe('createStorageRecord', () => { ...options, writeOptions: {} }) - ).resolves.toEqual(['123', '456']) + ).resolves.toEqual([123, 456]) }) }) }) diff --git a/packages/attest/src/artifactMetadata.ts b/packages/attest/src/artifactMetadata.ts index bb20bf68..6a5c514f 100644 --- a/packages/attest/src/artifactMetadata.ts +++ b/packages/attest/src/artifactMetadata.ts @@ -51,7 +51,7 @@ export type StorageRecordOptions = { */ export async function createStorageRecord( options: StorageRecordOptions -): Promise { +): Promise { const retries = options.writeOptions.retry ?? DEFAULT_RETRY_COUNT const octokit = github.getOctokit(options.token, {retry: {retries}}, retry) @@ -67,7 +67,7 @@ export async function createStorageRecord( ? JSON.parse(response.data) : response.data - return data?.storage_records.map((r: {id: number}) => String(r.id)) + return data?.storage_records.map((r: {id: number}) => r.id) } catch (err) { const message = err instanceof Error ? err.message : err throw new Error(`Failed to persist storage record: ${message}`)