From f375b23bb5325f31909ee25d7288a91de64fd52b Mon Sep 17 00:00:00 2001 From: Mara Nikola Kiefer Date: Mon, 13 Apr 2026 14:25:51 +0200 Subject: [PATCH] Add warning for unnormalizable SVG icon names --- script/sync-ghes/index.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/script/sync-ghes/index.ts b/script/sync-ghes/index.ts index 072132d..b8b705e 100755 --- a/script/sync-ghes/index.ts +++ b/script/sync-ghes/index.ts @@ -58,6 +58,9 @@ async function checkWorkflows( )); const iconName: string | undefined = workflowProperties["iconName"]; const normalizedSvgIconName = normalizeSvgIconName(iconName); + if (iconName && !normalizedSvgIconName) { + console.warn(`Warning: could not normalize icon "${iconName}" for workflow ${workflowId}, skipping icon sync`); + } const isPartnerWorkflow = workflowProperties.creator ? partnersSet.has(workflowProperties.creator.toLowerCase()) : false; @@ -71,7 +74,7 @@ async function checkWorkflows( id: workflowId, iconName: normalizedSvgIconName, iconType: - iconName && iconName.startsWith("octicon") ? "octicon" : "svg", + normalizedSvgIconName && normalizedSvgIconName.startsWith("octicon") ? "octicon" : "svg", }; if (!enabled) { @@ -190,7 +193,7 @@ async function checkWorkflow( r.push(join(x.folder, "properties", `${x.id}.properties.json`)); }; - if (x.iconType === "svg") { + if (x.iconType === "svg" && x.iconName) { r.push( join( "../../icons",