From ed1d73eb989689c28f93b74aa9a6fdaf49c3819c Mon Sep 17 00:00:00 2001 From: "Justin Goshi (from Dev Box)" Date: Fri, 4 Aug 2023 06:37:11 -1000 Subject: [PATCH] Respond to PR comments --- ci/cmake-multi-platform.yml | 14 +++++++------- ci/properties/cmake-multi-platform.json | 2 +- ci/properties/cmake-single-platform.json | 2 +- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/ci/cmake-multi-platform.yml b/ci/cmake-multi-platform.yml index dd5e5c4..774ba90 100644 --- a/ci/cmake-multi-platform.yml +++ b/ci/cmake-multi-platform.yml @@ -52,24 +52,24 @@ jobs: id: strings shell: bash run: | - echo "build-output-dir=${{github.workspace}}/build" >> "$GITHUB_OUTPUT" + echo "build-output-dir=${{ github.workspace }}/build" >> "$GITHUB_OUTPUT" - name: Configure CMake # Configure CMake in a 'build' subdirectory. `CMAKE_BUILD_TYPE` is only required if you are using a single-configuration generator such as make. # See https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html?highlight=cmake_build_type run: > cmake -B ${{ steps.strings.outputs.build-output-dir }} - -DCMAKE_CXX_COMPILER=${{matrix.cpp_compiler}} - -DCMAKE_C_COMPILER=${{matrix.c_compiler}} - -DCMAKE_BUILD_TYPE=${{matrix.build_type}} - -S ${{github.workspace}} + -DCMAKE_CXX_COMPILER=${{ matrix.cpp_compiler }} + -DCMAKE_C_COMPILER=${{ matrix.c_compiler }} + -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} + -S ${{ github.workspace }} - name: Build # Build your program with the given configuration. Note that --config is needed because the default Windows generator is a multi-config generator (Visual Studio generator). - run: cmake --build ${{ steps.strings.outputs.build-output-dir }} --config ${{matrix.build_type}} + run: cmake --build ${{ steps.strings.outputs.build-output-dir }} --config ${{ matrix.build_type }} - name: Test working-directory: ${{ steps.strings.outputs.build-output-dir }} # Execute tests defined by the CMake configuration. Note that -C is needed because the default Windows generator is a multi-config generator (Visual Studio generator). # See https://cmake.org/cmake/help/latest/manual/ctest.1.html for more detail - run: ctest --build-config ${{matrix.build_type}} + run: ctest --build-config ${{ matrix.build_type }} diff --git a/ci/properties/cmake-multi-platform.json b/ci/properties/cmake-multi-platform.json index ef44fcf..59d1b47 100644 --- a/ci/properties/cmake-multi-platform.json +++ b/ci/properties/cmake-multi-platform.json @@ -3,4 +3,4 @@ "description": "Build and test a CMake based project on multiple platforms.", "iconName": "cmake", "categories": ["Continuous integration", "C", "C++"] -} \ No newline at end of file +} diff --git a/ci/properties/cmake-single-platform.json b/ci/properties/cmake-single-platform.json index 8c7260e..c0aa074 100644 --- a/ci/properties/cmake-single-platform.json +++ b/ci/properties/cmake-single-platform.json @@ -3,4 +3,4 @@ "description": "Build and test a CMake based project on a single-platform.", "iconName": "cmake", "categories": ["Continuous integration", "C", "C++"] -} \ No newline at end of file +}