From 5699eea8b26807cbe73f3bd9293de111b3a05c1a Mon Sep 17 00:00:00 2001 From: Sheeri Cabral Date: Tue, 27 Oct 2020 12:25:47 -0400 Subject: [PATCH 1/2] Get rid of quoting that breaks by default. it looks like someone tried to use '' to make a ' happen for the possessive tense of users. But that messes up the quoting: issue-message: 'Message that will be displayed on users'' first issue' pr-message: 'Message that will be displayed on users'' first pr' It should be: issue-message: 'Message that will be displayed on the first issue for that user' pr-message: 'Message that will be displayed on the first pr for that user' (this gets rid of the spurious quotes, but also doesn't introduce any grammatical errors) It was a very bad impression to have a simple script designed to welcome folks be broken by default. --- automation/greetings.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/automation/greetings.yml b/automation/greetings.yml index 28ee6b2..cd3ebe2 100644 --- a/automation/greetings.yml +++ b/automation/greetings.yml @@ -9,5 +9,5 @@ jobs: - uses: actions/first-interaction@v1 with: repo-token: ${{ secrets.GITHUB_TOKEN }} - issue-message: 'Message that will be displayed on users'' first issue' - pr-message: 'Message that will be displayed on users'' first pr' + issue-message: 'Message that will be displayed on users' + pr-message: 'Message that will be displayed on users' From f631f1f2a9b6c0f3bb7257185e0c0933752bcdf4 Mon Sep 17 00:00:00 2001 From: Andy McKay Date: Mon, 4 Jan 2021 08:40:18 -0800 Subject: [PATCH 2/2] Update automation/greetings.yml --- automation/greetings.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/automation/greetings.yml b/automation/greetings.yml index cd3ebe2..ebb00a0 100644 --- a/automation/greetings.yml +++ b/automation/greetings.yml @@ -9,5 +9,5 @@ jobs: - uses: actions/first-interaction@v1 with: repo-token: ${{ secrets.GITHUB_TOKEN }} - issue-message: 'Message that will be displayed on users' - pr-message: 'Message that will be displayed on users' + issue-message: 'Message that will be displayed on users first issue' + pr-message: 'Message that will be displayed on users first pull request'