Resolve reviews

Signed-off-by: divyansh42 <[email protected]>
This commit is contained in:
divyansh42
2021-03-24 20:21:19 +05:30
parent 7c8569ab2b
commit c08e24c17b
+3 -4
View File
@@ -53,7 +53,6 @@ env:
# If you wish to manually provide the APP_NAME and TAG, set them here, otherwise they will be auto-detected. # If you wish to manually provide the APP_NAME and TAG, set them here, otherwise they will be auto-detected.
APP_NAME: "" APP_NAME: ""
TAG: "" TAG: ""
on: on:
@@ -88,7 +87,7 @@ jobs:
core.warning(`Secret "${name}" is not set`); core.warning(`Secret "${name}" is not set`);
return true; return true;
} }
core.info(` ✔️ Secret "${name}" is set`); core.info(`✔️ Secret "${name}" is set`);
return false; return false;
}); });
@@ -96,8 +95,8 @@ jobs:
if (missingSecrets.length > 0) { if (missingSecrets.length > 0) {
core.setFailed(`❌ At least one required secret is not set in the repository. \n` + core.setFailed(`❌ At least one required secret is not set in the repository. \n` +
"You can add it using:\n" + "You can add it using:\n" +
"Github UI: https://docs.github.com/en/actions/reference/encrypted-secrets#creating-encrypted-secrets-for-a-repository \n" + "GitHub UI: https://docs.github.com/en/actions/reference/encrypted-secrets#creating-encrypted-secrets-for-a-repository \n" +
"Github CLI: https://cli.github.com/manual/gh_secret_set \n" + "GitHub CLI: https://cli.github.com/manual/gh_secret_set \n" +
"Also, refer to https://github.com/redhat-actions/oc-login#getting-started-with-the-action-or-see-example"); "Also, refer to https://github.com/redhat-actions/oc-login#getting-started-with-the-action-or-see-example");
} }
else { else {