From 8d7b3c7bb7014e0553557a3337258297786f47d3 Mon Sep 17 00:00:00 2001 From: Nick Fyson Date: Fri, 23 Oct 2020 15:30:48 +0100 Subject: [PATCH 01/19] add code scanning readme --- code-scanning/README.md | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 code-scanning/README.md diff --git a/code-scanning/README.md b/code-scanning/README.md new file mode 100644 index 0000000..5b910da --- /dev/null +++ b/code-scanning/README.md @@ -0,0 +1,4 @@ +# Code Scanning Workflows + +GitHub code scanning is a developer-first, GitHub-native approach to easily find security vulnerabilities before they reach production. Before you can configure code scanning for a repository, you must enable code scanning by adding a GitHub Actions workflow to the repository. For more information, see [Enabling Code Scanning for a repository](/github/finding-security-vulnerabilities-and-errors-in-your-code/enabling-code-scanning-for-a-repository). + From fecbb32bb8564fa1ef4b16ca5edb9e28b2793e17 Mon Sep 17 00:00:00 2001 From: Andy McKay Date: Tue, 27 Oct 2020 15:44:22 -0700 Subject: [PATCH 02/19] Rename label-close.yml to label-support.yml --- .github/workflows/{label-close.yml => label-support.yml} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/workflows/{label-close.yml => label-support.yml} (100%) diff --git a/.github/workflows/label-close.yml b/.github/workflows/label-support.yml similarity index 100% rename from .github/workflows/label-close.yml rename to .github/workflows/label-support.yml From d7ac62140faf23b67c29e892d4ce68342eb09609 Mon Sep 17 00:00:00 2001 From: Andy McKay Date: Tue, 27 Oct 2020 15:47:43 -0700 Subject: [PATCH 03/19] Create label-feature.yml --- .github/workflows/label-feature.yml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 .github/workflows/label-feature.yml diff --git a/.github/workflows/label-feature.yml b/.github/workflows/label-feature.yml new file mode 100644 index 0000000..96ac8c1 --- /dev/null +++ b/.github/workflows/label-feature.yml @@ -0,0 +1,19 @@ +name: Close as a feature +on: + issues: + types: [labeled] + +jobs: + build: + runs-on: ubuntu-latest + steps: + - name: Close Issue + uses: peter-evans/close-issue@v1 + if: contains(github.event.issue.labels.*.name, 'feature') + with: + comment: | + Thank you 🙇 for this request. This request has been classified as a feature by the maintainers. + + We take all the requests for features seriously and have passed this on to the internal teams for their consideration. + + Because any feature requires further maintenance and support in the long term by this team, we would like to exercise caution into adding new features. If this feature is something that can be implemented independently, please consider forking this repository and adding the feature. From f938476d14e4e0b67d0ef855443ef90760d2739b Mon Sep 17 00:00:00 2001 From: Devon Carew Date: Fri, 30 Oct 2020 12:46:33 -0700 Subject: [PATCH 04/19] Update dart.yml --- ci/dart.yml | 29 ++++++++++++++++++++++------- 1 file changed, 22 insertions(+), 7 deletions(-) diff --git a/ci/dart.yml b/ci/dart.yml index 6e1b2e3..a009d1d 100644 --- a/ci/dart.yml +++ b/ci/dart.yml @@ -1,4 +1,4 @@ -name: Dart CI +name: Dart on: push: @@ -8,15 +8,30 @@ on: jobs: build: - runs-on: ubuntu-latest + # Note that this workflow uses the latest stable version of the Dart SDK. + # Docker images for other release channels - like dev and beta - are also + # available. See https://hub.docker.com/r/google/dart/ for the available + # images. container: image: google/dart:latest steps: - - uses: actions/checkout@v2 - - name: Install dependencies - run: pub get - - name: Run tests - run: pub run test + - uses: actions/checkout@v2 + + - name: Install package dependencies + run: pub get + + # Comment this step in to verify the use of 'dart format' on each commit. + # - name: Check formatting + # run: dart format --output=none --set-exit-if-changed . + + - name: Analyze code + run: dart analyze + + # Your project will need to have tests in test/ and a dependency on + # package:test for this step to succeed. Note that Flutter projects will + # want to change this to 'flutter test'. + - name: Run tests + run: dart test From 17e1df2111a39afa88818422bfcf7679fd7d5c14 Mon Sep 17 00:00:00 2001 From: Devon Carew Date: Mon, 2 Nov 2020 09:07:53 -0800 Subject: [PATCH 05/19] Update dart.yml Review comments from @mit-mit. --- ci/dart.yml | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/ci/dart.yml b/ci/dart.yml index a009d1d..d3ad4f8 100644 --- a/ci/dart.yml +++ b/ci/dart.yml @@ -20,18 +20,22 @@ jobs: steps: - uses: actions/checkout@v2 - - name: Install package dependencies - run: pub get + - name: dart --version + run: dart --version - # Comment this step in to verify the use of 'dart format' on each commit. - # - name: Check formatting + - name: dart pub get + run: dart pub get + + # Uncomment this step to verify the use of 'dart format' on each commit. + # - name: dart format # run: dart format --output=none --set-exit-if-changed . - - name: Analyze code + # Consider passing '--fatal-infos' for slightly stricter analysis. + - name: dart analyze run: dart analyze # Your project will need to have tests in test/ and a dependency on # package:test for this step to succeed. Note that Flutter projects will # want to change this to 'flutter test'. - - name: Run tests + - name: dart test run: dart test From e2510e2a621b7406de1d343fcb3efeb4ed48e579 Mon Sep 17 00:00:00 2001 From: Usha N Date: Tue, 3 Nov 2020 18:21:34 +0530 Subject: [PATCH 06/19] Updating the pre-req configuration steps For Linux Apps, Developers need to set a new app setting called WEBSITE_WEBDEPLOY_USE_SCM and set to `true` before downloading the publish profile. --- ci/azure.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/ci/azure.yml b/ci/azure.yml index a638c4c..2678376 100644 --- a/ci/azure.yml +++ b/ci/azure.yml @@ -5,10 +5,13 @@ # # To configure this workflow: # -# 1. Set up a secret in your repository named AZURE_WEBAPP_PUBLISH_PROFILE with the value of your Azure publish profile. +# 1. For Linux apps, add an app setting called WEBSITE_WEBDEPLOY_USE_SCM and set it to true in your app. +# For more instructions see: +# +# 2. Set up a secret in your repository named AZURE_WEBAPP_PUBLISH_PROFILE with the value of your Azure publish profile. # For instructions on obtaining the publish profile see: https://docs.microsoft.com/azure/app-service/deploy-github-actions#configure-the-github-secret # -# 2. Change the values for the AZURE_WEBAPP_NAME, AZURE_WEBAPP_PACKAGE_PATH and NODE_VERSION environment variables (below). +# 3. Change the values for the AZURE_WEBAPP_NAME, AZURE_WEBAPP_PACKAGE_PATH and NODE_VERSION environment variables (below). # # For more information on GitHub Actions for Azure, refer to https://github.com/Azure/Actions # For more samples to get started with GitHub Action workflows to deploy to Azure, refer to https://github.com/Azure/actions-workflow-samples From dfaa4e420b04976270ea2f53f4de37f47aca6175 Mon Sep 17 00:00:00 2001 From: Nemo Xiong Date: Thu, 5 Nov 2020 01:57:31 +0800 Subject: [PATCH 07/19] remove misleading info python-django.* has renamed to django.*, while the doc remains the same --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index fdd9bf8..6025c5c 100644 --- a/README.md +++ b/README.md @@ -17,7 +17,7 @@ These are the workflow files for helping people get started with GitHub Actions. Each workflow must be written in YAML and have a `.yml` extension. They also need a corresponding `.properties.json` file that contains extra metadata about the workflow (this is displayed in the GitHub.com UI). -For example: `ci/python-django.yml` and `ci/properties/python-django.properties.json`. +For example: `ci/django.yml` and `ci/properties/django.properties.json`. **Valid properties:** * `name`: the name shown in onboarding From f75012de65c4d2e22b548521929b053e5c929737 Mon Sep 17 00:00:00 2001 From: Kayla Ngan Date: Wed, 4 Nov 2020 16:32:58 -0500 Subject: [PATCH 08/19] Revert "Update Publish Docker template to publish to GitHub Container Registry" --- ci/docker-publish.yml | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/ci/docker-publish.yml b/ci/docker-publish.yml index fc5439b..76756db 100644 --- a/ci/docker-publish.yml +++ b/ci/docker-publish.yml @@ -50,13 +50,12 @@ jobs: - name: Build image run: docker build . --file Dockerfile --tag $IMAGE_NAME - - name: Log into GitHub Container Registry - # TODO: Create a PAT with `read:packages` and `write:packages` scopes and save it as an Actions secret `CR_PAT` - run: echo "${{ secrets.CR_PAT }}" | docker login https://ghcr.io -u ${{ github.actor }} --password-stdin + - name: Log into registry + run: echo "${{ secrets.GITHUB_TOKEN }}" | docker login docker.pkg.github.com -u ${{ github.actor }} --password-stdin - - name: Push image to GitHub Container Registry + - name: Push image run: | - IMAGE_ID=ghcr.io/${{ github.repository_owner }}/$IMAGE_NAME + IMAGE_ID=docker.pkg.github.com/${{ github.repository }}/$IMAGE_NAME # Change all uppercase to lowercase IMAGE_ID=$(echo $IMAGE_ID | tr '[A-Z]' '[a-z]') From 5aeeb19100f15129efbaa9025bcffcbd1a674e71 Mon Sep 17 00:00:00 2001 From: Usha N Date: Thu, 5 Nov 2020 22:32:30 +0530 Subject: [PATCH 09/19] Update azure.yml --- ci/azure.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ci/azure.yml b/ci/azure.yml index 2678376..5842381 100644 --- a/ci/azure.yml +++ b/ci/azure.yml @@ -5,8 +5,8 @@ # # To configure this workflow: # -# 1. For Linux apps, add an app setting called WEBSITE_WEBDEPLOY_USE_SCM and set it to true in your app. -# For more instructions see: +# 1. For Linux apps, add an app setting called WEBSITE_WEBDEPLOY_USE_SCM and set it to true in your app **before downloading the file**. +# For more instructions see: https://docs.microsoft.com/azure/app-service/configure-common#configure-app-settings # # 2. Set up a secret in your repository named AZURE_WEBAPP_PUBLISH_PROFILE with the value of your Azure publish profile. # For instructions on obtaining the publish profile see: https://docs.microsoft.com/azure/app-service/deploy-github-actions#configure-the-github-secret From 33e4b7e557c644fcc918d862907b5753f4d55152 Mon Sep 17 00:00:00 2001 From: Nick Fyson Date: Mon, 9 Nov 2020 10:09:50 +0000 Subject: [PATCH 10/19] add codeql workflow --- code-scanning/codeql.yml | 67 +++++++++++++++++++ .../properties/codeql.properties.json | 7 ++ 2 files changed, 74 insertions(+) create mode 100644 code-scanning/codeql.yml create mode 100644 code-scanning/properties/codeql.properties.json diff --git a/code-scanning/codeql.yml b/code-scanning/codeql.yml new file mode 100644 index 0000000..09d68ef --- /dev/null +++ b/code-scanning/codeql.yml @@ -0,0 +1,67 @@ +# For most projects, this workflow file will not need changing; you simply need +# to commit it to your repository. +# +# You may wish to alter this file to override the set of languages analyzed, +# or to provide custom queries or build logic. +# +# ******** NOTE ******** +# We have attempted to detect the languages in your repository. Please check +# the `language` matrix defined below to confirm you have the correct set of +# supported CodeQL languages. +# +name: "CodeQL" + +on: + push: + branches: [ $default-branch, $protected-branches ] + pull_request: + # The branches below must be a subset of the branches above + branches: [ $default-branch ] + schedule: + - cron: $cron-weekly + +jobs: + analyze: + name: Analyze + runs-on: ubuntu-latest + + strategy: + fail-fast: false + matrix: + language: [ $detected-codeql-languages ] + # CodeQL supports [ $supported-codeql-languages ] + # Learn more... + # https://docs.github.com/en/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#overriding-automatic-language-detection + + steps: + - name: Checkout repository + uses: actions/checkout@v2 + + # Initializes the CodeQL tools for scanning. + - name: Initialize CodeQL + uses: github/codeql-action/init@v1 + with: + languages: ${{ matrix.language }} + # If you wish to specify custom queries, you can do so here or in a config file. + # By default, queries listed here will override any specified in a config file. + # Prefix the list here with "+" to use these queries and those in the config file. + # queries: ./path/to/local/query, your-org/your-repo/queries@main + + # Autobuild attempts to build any compiled languages (C/C++, C#, or Java). + # If this step fails, then you should remove it and run the build manually (see below) + - name: Autobuild + uses: github/codeql-action/autobuild@v1 + + # ℹī¸ Command-line programs to run using the OS shell. + # 📚 https://git.io/JvXDl + + # ✏ī¸ If the Autobuild fails above, remove it and uncomment the following three lines + # and modify them (or add more) to build your code if your project + # uses a compiled language + + #- run: | + # make bootstrap + # make release + + - name: Perform CodeQL Analysis + uses: github/codeql-action/analyze@v1 diff --git a/code-scanning/properties/codeql.properties.json b/code-scanning/properties/codeql.properties.json new file mode 100644 index 0000000..cb9305a --- /dev/null +++ b/code-scanning/properties/codeql.properties.json @@ -0,0 +1,7 @@ +{ + "name": "CodeQL Analysis", + "creator": "GitHub", + "description": "Security analysis from GitHub for C, C++, C#, Java, JavaScript, TypeScript, Python, and Go developers.", + "iconName": "octicon mark-github", + "categories": ["Code Scanning", "C", "C#", "C++", "Go", "Java", "JavaScript", "TypeScript", "Python"] +} From 1e97b0eba71cf363b419bc663212c01e163359e6 Mon Sep 17 00:00:00 2001 From: Devon Carew Date: Mon, 9 Nov 2020 09:54:52 -0800 Subject: [PATCH 11/19] Update dart.yml Change to sentence fragment case for the step names --- ci/dart.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ci/dart.yml b/ci/dart.yml index d3ad4f8..138921f 100644 --- a/ci/dart.yml +++ b/ci/dart.yml @@ -20,22 +20,22 @@ jobs: steps: - uses: actions/checkout@v2 - - name: dart --version + - name: Print Dart SDK version run: dart --version - - name: dart pub get + - name: Install dependencies run: dart pub get # Uncomment this step to verify the use of 'dart format' on each commit. - # - name: dart format + # - name: Verify formatting # run: dart format --output=none --set-exit-if-changed . # Consider passing '--fatal-infos' for slightly stricter analysis. - - name: dart analyze + - name: Analyze project source run: dart analyze # Your project will need to have tests in test/ and a dependency on # package:test for this step to succeed. Note that Flutter projects will # want to change this to 'flutter test'. - - name: dart test + - name: Run tests run: dart test From 33c4d0afcb8b5c43c5bead1cfd2b33d149f65d4e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Anders=20Hovm=C3=B6ller?= Date: Tue, 10 Nov 2020 13:57:09 +0100 Subject: [PATCH 12/19] Prepare python-package.yml for python 3.10 Python 3.10 is coming soon, and this will cause problems with the code as currently written. The python versions are written as floats and not strings, which will mean that 3.10 == 3.1, which is going to be very surprising. --- ci/python-package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/python-package.yml b/ci/python-package.yml index c4a1081..ca1713a 100644 --- a/ci/python-package.yml +++ b/ci/python-package.yml @@ -15,7 +15,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - python-version: [3.5, 3.6, 3.7, 3.8] + python-version: ['3.5', '3.6', '3.7', '3.8'] steps: - uses: actions/checkout@v2 From 85739b01da473f4e2b77b53ffefd42338e600dff Mon Sep 17 00:00:00 2001 From: Nick Fyson Date: Wed, 11 Nov 2020 09:30:58 +0000 Subject: [PATCH 13/19] update terms and guidelines to account for code scanning workflows --- .github/pull_request_template.md | 11 ++++++----- CONTRIBUTING.md | 8 ++++---- LICENSE | 3 ++- README.md | 1 + 4 files changed, 13 insertions(+), 10 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index e79272c..67a60a7 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,4 +1,4 @@ -This repository contains configuration for what users see when they click on the `Actions` tab. +This repository contains configuration for what users see when they click on the `Actions` tab and the setup page for Code Scanning. It is not: * A playground to try out scripts @@ -6,7 +6,7 @@ It is not: --- -**Please note that we are not accepting new starter workflows at this time. Updates to existing starter workflows are fine.** +**Please note that at this time we are only accepting new starter workflows for Code Scanning. Updates to existing starter workflows are fine.** --- @@ -21,16 +21,17 @@ In the workflow and properties files: - [ ] Include comments in the workflow for any parts that are not obvious or could use clarification. - [ ] CI workflows should run on `push` to `branches: [ $default-branch ]` and `pull_request` to `branches: [ $default-branch ]`. - [ ] Packaging workflows should run on `release` with `types: [ created ]`. +- [ ] Code Scanning workflows should run on `push` to `branches: [ $default-branch, $protected-branches ]` and `pull_request` to `branches: [ $default-branch ]`. We also recommend a `schedule` trigger of `cron: $cron-weekly`. Some general notes: - [ ] This workflow must only use actions that are produced by GitHub, [in the `actions` organization](https://github.com/actions), **or** -- [ ] This workflow must only use actions that are produced by the language or ecosystem that the workflow supports. These actions must be [published to the GitHub Marketplace](https://github.com/marketplace?type=actions). Workflows using these actions must reference the action using the full 40 character hash of the action's commit instead of a tag. Additionally, workflows must include the following comment at the top of the workflow file: +- [ ] This workflow must only use actions that are produced by the language or ecosystem that the workflow supports. These actions must be [published to the GitHub Marketplace](https://github.com/marketplace?type=actions). We recommend that these actions be referenced using the full 40 character hash of the action's commit instead of a tag. Additionally, workflows must include the following comment at the top of the workflow file: ``` # This workflow uses actions that are not certified by GitHub. # They are provided by a third-party and are governed by # separate terms of service, privacy policy, and support # documentation. ``` -- [ ] This workflow must not send data to any 3rd party service except for the purposes of installing dependencies. -- [ ] This workflow must not use a paid service or product. +- [ ] Automation and CI workflows should not send data to any 3rd party service except for the purposes of installing dependencies. +- [ ] Automation and CI workflows cannot be dependent on a paid service or product. diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8f9d704..c9e8299 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -9,7 +9,7 @@ Contributions to this project are [released](https://help.github.com/articles/gi Please note that this project is released with a [Contributor Code of Conduct]( https://github.com/actions/.github/blob/main/CODE_OF_CONDUCT.md). By participating in this project you agree to abide by its terms. -**At this time we are not accepting any new starter workflows** +**At this time we are only accepting new starter workflows for Code Scanning** ### Previous guidelines for new starter workflows. @@ -17,8 +17,8 @@ Before merging a new workflow, the following requirements need to be met: - Should be as simple as is needed for the service. - There are many programming languages and tools out there. Right now we don't have a page that allows for a really large number of workflows, so we do have to be a little choosy about what we accept. Less popular tools or languages might not be accepted. -- Should not send data to any 3rd party service except for the purposes of installing dependencies. -- Cannot use an Action that isn't in the `actions` organization. -- Cannot be to a paid service or product. +- Automation and CI workflows should not send data to any 3rd party service except for the purposes of installing dependencies. +- Automation and CI workflows cannot be dependent on a paid service or product. +- We recommend that Actions outside of the `actions` organization be pinned to a specific SHA. Thank you diff --git a/LICENSE b/LICENSE index 331b241..658b968 100644 --- a/LICENSE +++ b/LICENSE @@ -18,4 +18,5 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE -SOFTWARE. +SOFTWARE. THIS LICENSE DOES NOT GRANT YOU RIGHTS TO USE ANY CONTRIBUTORS' +NAME, LOGO, OR TRADEMARKS. diff --git a/README.md b/README.md index 6025c5c..e276691 100644 --- a/README.md +++ b/README.md @@ -13,6 +13,7 @@ These are the workflow files for helping people get started with GitHub Actions. **Directory structure:** * [ci](ci): solutions for Continuous Integration * [automation](automation): solutions for automating workflows. +* [code-scanning](code-scanning): starter workflows for [Code Scanning](https://github.com/features/security) * [icons](icons): svg icons for the relevant template Each workflow must be written in YAML and have a `.yml` extension. They also need a corresponding `.properties.json` file that contains extra metadata about the workflow (this is displayed in the GitHub.com UI). From 500534878c28b83304ed572c7e9df8efa9ce86d8 Mon Sep 17 00:00:00 2001 From: Nick Fyson Date: Thu, 12 Nov 2020 12:42:47 +0000 Subject: [PATCH 14/19] update doc link in codeql template --- code-scanning/codeql.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/code-scanning/codeql.yml b/code-scanning/codeql.yml index 09d68ef..3e8f951 100644 --- a/code-scanning/codeql.yml +++ b/code-scanning/codeql.yml @@ -30,8 +30,8 @@ jobs: matrix: language: [ $detected-codeql-languages ] # CodeQL supports [ $supported-codeql-languages ] - # Learn more... - # https://docs.github.com/en/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#overriding-automatic-language-detection + # Learn more: + # https://docs.github.com/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#changing-the-languages-that-are-analyzed steps: - name: Checkout repository From 44c50acb70a47e6f3179276ba7ff9b7154a015cf Mon Sep 17 00:00:00 2001 From: Nick Fyson Date: Fri, 13 Nov 2020 16:33:01 +0000 Subject: [PATCH 15/19] amend link in codeql workflow --- code-scanning/codeql.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code-scanning/codeql.yml b/code-scanning/codeql.yml index 3e8f951..d88fe52 100644 --- a/code-scanning/codeql.yml +++ b/code-scanning/codeql.yml @@ -31,7 +31,7 @@ jobs: language: [ $detected-codeql-languages ] # CodeQL supports [ $supported-codeql-languages ] # Learn more: - # https://docs.github.com/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#changing-the-languages-that-are-analyzed + # https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#changing-the-languages-that-are-analyzed steps: - name: Checkout repository From ef7878c3e6b351a5baf052d25ce729e19680902c Mon Sep 17 00:00:00 2001 From: Christopher Schleiden Date: Thu, 19 Nov 2020 14:07:15 -0800 Subject: [PATCH 16/19] Add workflow_dispatch trigger to the default empty workflow --- ci/blank.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/ci/blank.yml b/ci/blank.yml index f7816e9..79ba948 100644 --- a/ci/blank.yml +++ b/ci/blank.yml @@ -2,14 +2,17 @@ name: CI -# Controls when the action will run. Triggers the workflow on push or pull request -# events but only for the $default-branch branch +# Controls when the action will run. on: + # Triggers the workflow on push or pull request events but only for the $default-branch branch push: branches: [ $default-branch ] pull_request: branches: [ $default-branch ] + # This allows you to run this workflow manually from the Actions tab + workflow_dispatch: + # A workflow run is made up of one or more jobs that can run sequentially or in parallel jobs: # This workflow contains a single job called "build" From bfb45aec418510a5b68ad15395694db7907eca58 Mon Sep 17 00:00:00 2001 From: Christopher Schleiden Date: Thu, 19 Nov 2020 14:21:12 -0800 Subject: [PATCH 17/19] Shorten the description --- ci/blank.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/blank.yml b/ci/blank.yml index 79ba948..3214287 100644 --- a/ci/blank.yml +++ b/ci/blank.yml @@ -10,7 +10,7 @@ on: pull_request: branches: [ $default-branch ] - # This allows you to run this workflow manually from the Actions tab + # Allows you to run this workflow manually from the Actions tab workflow_dispatch: # A workflow run is made up of one or more jobs that can run sequentially or in parallel From 0e2cd77dc8a2aa3769619b37929a26765894e87a Mon Sep 17 00:00:00 2001 From: Robert Rosca <32569096+RobertRosca@users.noreply.github.com> Date: Mon, 23 Nov 2020 11:13:06 +0100 Subject: [PATCH 18/19] Use consistent calls to pip `pip` was called in two different ways which is a bit inconsistent, this change just makes it so that it is called in the same way both times. --- ci/python-package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/python-package.yml b/ci/python-package.yml index c4a1081..403cecd 100644 --- a/ci/python-package.yml +++ b/ci/python-package.yml @@ -26,7 +26,7 @@ jobs: - name: Install dependencies run: | python -m pip install --upgrade pip - pip install flake8 pytest + python -m pip install flake8 pytest if [ -f requirements.txt ]; then pip install -r requirements.txt; fi - name: Lint with flake8 run: | From 64f653a8091f84182b1aa45ce63b0caaddfb94cd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oliver=20St=C3=A4bler?= Date: Tue, 24 Nov 2020 21:16:36 +0100 Subject: [PATCH 19/19] Build/Test all go packages Use the "..." pattern to build/test all go packages in a repository. --- ci/go.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ci/go.yml b/ci/go.yml index 5531663..16bff70 100644 --- a/ci/go.yml +++ b/ci/go.yml @@ -30,7 +30,7 @@ jobs: fi - name: Build - run: go build -v . + run: go build -v ./... - name: Test - run: go test -v . + run: go test -v ./...