Addressing PR Comments from Community

This commit is contained in:
mvecha
2022-04-21 15:20:01 +05:30
parent 74471dae6f
commit 73afccbbd5
2 changed files with 11 additions and 6 deletions
@@ -3,5 +3,5 @@
"creator": "Zscaler CWP", "creator": "Zscaler CWP",
"description": "Scan your Infrastructure as Code files using Zscaler Infrastructure as Code (IaC) Scan app", "description": "Scan your Infrastructure as Code files using Zscaler Infrastructure as Code (IaC) Scan app",
"iconName": "zscaler", "iconName": "zscaler",
"categories": ["Code Scanning","Security"] "categories": ["Code Scanning"]
} }
+10 -5
View File
@@ -7,6 +7,14 @@
#which detects security misconfigurations in IaC templates and publishes the findings #which detects security misconfigurations in IaC templates and publishes the findings
#under the code scanning alerts section within the repository. #under the code scanning alerts section within the repository.
#Log into the Zscaler Workload Posture (ZWP) Admin Portal to begin the onboarding process.
#Copy the client ID and client secret key generated during the onboarding process and configure.
#GitHub secrets (ZSCANNER_CLIENT_ID, ZSCANNER_CLIENT_SECRET).
#Refer https://github.com/marketplace/actions/zscaler-iac-scan for additional details on setting up this workflow.
#Any issues with this workflow, please raise it on https://github.com/ZscalerCWP/Zscaler-IaC-Action/issues
#for further investigation.
name: Zscaler IaC Scan name: Zscaler IaC Scan
on: on:
push: push:
@@ -27,14 +35,11 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- name : Code Checkout - name : Code Checkout
uses: actions/checkout@v2 uses: actions/checkout@v3
- name : Zscaler IAC Scan - name : Zscaler IAC Scan
uses : ZscalerCWP/Zscaler-IaC-Action@8f0d8b60bd5a8f44062d444463f66f419ab71cfc uses : ZscalerCWP/Zscaler-IaC-Action@8f0d8b60bd5a8f44062d444463f66f419ab71cfc
id : zscaler-iac-scan id : zscaler-iac-scan
with: with:
#Log into the Zscaler Workload Posture (ZWP) Admin Portal to begin the onboarding process.
#Copy the client ID and client secret key generated during the onboarding process and configure.
#GitHub secrets (ZSCANNER_CLIENT_ID, ZSCANNER_CLIENT_SECRET).
client_id : ${{ secrets.ZSCANNER_CLIENT_ID }} client_id : ${{ secrets.ZSCANNER_CLIENT_ID }}
client_secret : ${{ secrets.ZSCANNER_CLIENT_SECRET }} client_secret : ${{ secrets.ZSCANNER_CLIENT_SECRET }}
#This is the user region specified during the onboarding process within the ZWP Admin Portal. #This is the user region specified during the onboarding process within the ZWP Admin Portal.
@@ -47,6 +52,6 @@ jobs:
#Ensure that the following step is included in order to post the scan results under the code scanning alerts section within the repository. #Ensure that the following step is included in order to post the scan results under the code scanning alerts section within the repository.
- name: Upload SARIF file - name: Upload SARIF file
if: ${{ success() || failure() && (steps.zscaler-iac-scan.outputs.sarif_file_path != '') }} if: ${{ success() || failure() && (steps.zscaler-iac-scan.outputs.sarif_file_path != '') }}
uses: github/codeql-action/upload-sarif@v1 uses: github/codeql-action/upload-sarif@v2
with: with:
sarif_file: ${{ steps.zscaler-iac-scan.sarif_file_path }} sarif_file: ${{ steps.zscaler-iac-scan.sarif_file_path }}