From f938476d14e4e0b67d0ef855443ef90760d2739b Mon Sep 17 00:00:00 2001 From: Devon Carew Date: Fri, 30 Oct 2020 12:46:33 -0700 Subject: [PATCH 1/4] Update dart.yml --- ci/dart.yml | 29 ++++++++++++++++++++++------- 1 file changed, 22 insertions(+), 7 deletions(-) diff --git a/ci/dart.yml b/ci/dart.yml index 6e1b2e3..a009d1d 100644 --- a/ci/dart.yml +++ b/ci/dart.yml @@ -1,4 +1,4 @@ -name: Dart CI +name: Dart on: push: @@ -8,15 +8,30 @@ on: jobs: build: - runs-on: ubuntu-latest + # Note that this workflow uses the latest stable version of the Dart SDK. + # Docker images for other release channels - like dev and beta - are also + # available. See https://hub.docker.com/r/google/dart/ for the available + # images. container: image: google/dart:latest steps: - - uses: actions/checkout@v2 - - name: Install dependencies - run: pub get - - name: Run tests - run: pub run test + - uses: actions/checkout@v2 + + - name: Install package dependencies + run: pub get + + # Comment this step in to verify the use of 'dart format' on each commit. + # - name: Check formatting + # run: dart format --output=none --set-exit-if-changed . + + - name: Analyze code + run: dart analyze + + # Your project will need to have tests in test/ and a dependency on + # package:test for this step to succeed. Note that Flutter projects will + # want to change this to 'flutter test'. + - name: Run tests + run: dart test From 17e1df2111a39afa88818422bfcf7679fd7d5c14 Mon Sep 17 00:00:00 2001 From: Devon Carew Date: Mon, 2 Nov 2020 09:07:53 -0800 Subject: [PATCH 2/4] Update dart.yml Review comments from @mit-mit. --- ci/dart.yml | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/ci/dart.yml b/ci/dart.yml index a009d1d..d3ad4f8 100644 --- a/ci/dart.yml +++ b/ci/dart.yml @@ -20,18 +20,22 @@ jobs: steps: - uses: actions/checkout@v2 - - name: Install package dependencies - run: pub get + - name: dart --version + run: dart --version - # Comment this step in to verify the use of 'dart format' on each commit. - # - name: Check formatting + - name: dart pub get + run: dart pub get + + # Uncomment this step to verify the use of 'dart format' on each commit. + # - name: dart format # run: dart format --output=none --set-exit-if-changed . - - name: Analyze code + # Consider passing '--fatal-infos' for slightly stricter analysis. + - name: dart analyze run: dart analyze # Your project will need to have tests in test/ and a dependency on # package:test for this step to succeed. Note that Flutter projects will # want to change this to 'flutter test'. - - name: Run tests + - name: dart test run: dart test From dfaa4e420b04976270ea2f53f4de37f47aca6175 Mon Sep 17 00:00:00 2001 From: Nemo Xiong Date: Thu, 5 Nov 2020 01:57:31 +0800 Subject: [PATCH 3/4] remove misleading info python-django.* has renamed to django.*, while the doc remains the same --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index fdd9bf8..6025c5c 100644 --- a/README.md +++ b/README.md @@ -17,7 +17,7 @@ These are the workflow files for helping people get started with GitHub Actions. Each workflow must be written in YAML and have a `.yml` extension. They also need a corresponding `.properties.json` file that contains extra metadata about the workflow (this is displayed in the GitHub.com UI). -For example: `ci/python-django.yml` and `ci/properties/python-django.properties.json`. +For example: `ci/django.yml` and `ci/properties/django.properties.json`. **Valid properties:** * `name`: the name shown in onboarding From 1e97b0eba71cf363b419bc663212c01e163359e6 Mon Sep 17 00:00:00 2001 From: Devon Carew Date: Mon, 9 Nov 2020 09:54:52 -0800 Subject: [PATCH 4/4] Update dart.yml Change to sentence fragment case for the step names --- ci/dart.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ci/dart.yml b/ci/dart.yml index d3ad4f8..138921f 100644 --- a/ci/dart.yml +++ b/ci/dart.yml @@ -20,22 +20,22 @@ jobs: steps: - uses: actions/checkout@v2 - - name: dart --version + - name: Print Dart SDK version run: dart --version - - name: dart pub get + - name: Install dependencies run: dart pub get # Uncomment this step to verify the use of 'dart format' on each commit. - # - name: dart format + # - name: Verify formatting # run: dart format --output=none --set-exit-if-changed . # Consider passing '--fatal-infos' for slightly stricter analysis. - - name: dart analyze + - name: Analyze project source run: dart analyze # Your project will need to have tests in test/ and a dependency on # package:test for this step to succeed. Note that Flutter projects will # want to change this to 'flutter test'. - - name: dart test + - name: Run tests run: dart test