From 394301af94ed4c4a052d067ef69a71885bc0a297 Mon Sep 17 00:00:00 2001
From: Anurag Chauhan <44864882+anuragc617@users.noreply.github.com>
Date: Mon, 14 Feb 2022 10:11:33 +0000
Subject: [PATCH] Adding folder category check

---
 script/validate-data/index.ts      | 17 ++++++++++++-----
 script/validate-data/settings.json | 18 ++++++++++++++++++
 2 files changed, 30 insertions(+), 5 deletions(-)

diff --git a/script/validate-data/index.ts b/script/validate-data/index.ts
index 7dce3d1..6669b34 100755
--- a/script/validate-data/index.ts
+++ b/script/validate-data/index.ts
@@ -1,7 +1,7 @@
 #!/usr/bin/env npx ts-node
 import { promises as fs } from "fs";
 import { safeLoad } from "js-yaml";
-import { basename, extname, join } from "path";
+import { basename, extname, join, dirname } from "path";
 import { Validator as validator } from "jsonschema";
 import { endGroup, error, info, setFailed, startGroup } from '@actions/core';
 
@@ -40,7 +40,7 @@ const propertiesSchema = {
   }
 }
 
-async function checkWorkflows(folders: string[], allowed_categories: string[]): Promise<WorkflowWithErrors[]> {
+async function checkWorkflows(folders: string[], allowed_categories: string[], folder_category_map: object[]): Promise<WorkflowWithErrors[]> {
   const result: WorkflowWithErrors[] = []
   const workflow_template_names = new Set()
   for (const folder of folders) {
@@ -55,7 +55,7 @@ async function checkWorkflows(folders: string[], allowed_categories: string[]):
         const workflowFilePath = join(folder, e.name);
         const propertiesFilePath = join(folder, "properties", `${fileType}.properties.json`)
 
-        const workflowWithErrors = await checkWorkflow(workflowFilePath, propertiesFilePath, allowed_categories);
+        const workflowWithErrors = await checkWorkflow(workflowFilePath, propertiesFilePath, allowed_categories, folder_category_map);
         if(workflowWithErrors.name && workflow_template_names.size == workflow_template_names.add(workflowWithErrors.name).size) {
           workflowWithErrors.errors.push(`Workflow template name "${workflowWithErrors.name}" already exists`) 
         }
@@ -69,7 +69,7 @@ async function checkWorkflows(folders: string[], allowed_categories: string[]):
   return result;
 }
 
-async function checkWorkflow(workflowPath: string, propertiesPath: string, allowed_categories: string[]): Promise<WorkflowWithErrors> {
+async function checkWorkflow(workflowPath: string, propertiesPath: string, allowed_categories: string[], folder_category_map: object[]): Promise<WorkflowWithErrors> {
   let workflowErrors: WorkflowWithErrors = {
     id: workflowPath,
     name: null,
@@ -104,10 +104,17 @@ async function checkWorkflow(workflowPath: string, propertiesPath: string, allow
       }
       
     }
+    var directoryName = dirname(workflowPath)
+    var folder_category = folder_category_map.find( folder_category => folder_category["name"] == directoryName)["category"]
     if (!workflowPath.endsWith("blank.yml") && (!properties.categories || 
       !properties.categories.some(category => allowed_categories.some(ac => ac.toLowerCase() == category.toLowerCase())))) {
       workflowErrors.errors.push(`Workflow does not contain at least one allowed category - ${allowed_categories}`)
     }
+
+    if(properties.categories && !properties.categories.some(category => category.toLowerCase() == folder_category.toLowerCase())) {
+      workflowErrors.errors.push(`Either workflow is not added to the correct directory or category specified is wrong. Allowed category for ${basename(directoryName)} directory is ${folder_category}`)
+    }
+    
   } catch (e) {
     workflowErrors.errors.push(e.toString())
   }
@@ -118,7 +125,7 @@ async function checkWorkflow(workflowPath: string, propertiesPath: string, allow
   try {
     const settings = require("./settings.json");
     const erroredWorkflows = await checkWorkflows(
-      settings.folders, settings.allowed_categories
+      settings.folders, settings.allowed_categories, settings.folder_category_map
     )
 
     if (erroredWorkflows.length > 0) {
diff --git a/script/validate-data/settings.json b/script/validate-data/settings.json
index ce89e36..ab1ada3 100644
--- a/script/validate-data/settings.json
+++ b/script/validate-data/settings.json
@@ -10,5 +10,23 @@
     "Deployment",
     "Code Scanning",
     "Automation"
+  ],
+  "folder_category_map": [
+    {
+      "name":  "../../ci",
+      "category": "Continuous integration" 
+    },
+    {
+      "name": "../../automation",
+      "category": "Automation"
+    },
+    { 
+      "name": "../../deployments",
+      "category": "Deployment"
+    },
+    { 
+      "name": "../../code-scanning",
+      "category": "Code Scanning"
+    }
   ]
 }
\ No newline at end of file