From 6d1c317b90479ece122c7a576fb235aa29af2f4b Mon Sep 17 00:00:00 2001 From: Francesco Renzi Date: Mon, 24 Nov 2025 12:06:19 +0100 Subject: [PATCH] Return error on failed runner start (#17) --- examples/dockerscaleset/scaler.go | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/examples/dockerscaleset/scaler.go b/examples/dockerscaleset/scaler.go index c062f06..ad4449c 100644 --- a/examples/dockerscaleset/scaler.go +++ b/examples/dockerscaleset/scaler.go @@ -41,17 +41,12 @@ func (a *Scaler) HandleDesiredRunnerCount(ctx context.Context, count int) (int, slog.Int("scaleUp", scaleUp), ) - var errs []error for range scaleUp { if _, err := a.startRunner(ctx); err != nil { - errs = append(errs, err) + return 0, fmt.Errorf("failed to start runner: %w", err) } } - for _, err := range errs { - // TODO: should we return error? - a.logger.Error("Failed to start runner", slog.String("error", err.Error())) - } return a.runners.count(), nil default: // No need to handle scale down events, since: