Add error messages instead of just returning an error (#16)
* Add error messages instead of just returning an error * Apply suggestions from code review Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
This commit is contained in:
@@ -32,7 +32,7 @@ type GitHubConfig struct {
|
|||||||
func ParseGitHubConfigFromURL(in string) (*GitHubConfig, error) {
|
func ParseGitHubConfigFromURL(in string) (*GitHubConfig, error) {
|
||||||
u, err := url.Parse(strings.Trim(in, "/"))
|
u, err := url.Parse(strings.Trim(in, "/"))
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, fmt.Errorf("failed to parse URL: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
isHosted := isHostedGitHubURL(u)
|
isHosted := isHostedGitHubURL(u)
|
||||||
|
|||||||
@@ -76,7 +76,7 @@ func New(client *scaleset.Client, config Config) (*Listener, error) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
if err := config.Validate(); err != nil {
|
if err := config.Validate(); err != nil {
|
||||||
return nil, err
|
return nil, fmt.Errorf("invalid config: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
hostname, err := os.Hostname()
|
hostname, err := os.Hostname()
|
||||||
@@ -247,7 +247,7 @@ func (l *Listener) getMessage(ctx context.Context) (*scaleset.RunnerScaleSetMess
|
|||||||
}
|
}
|
||||||
|
|
||||||
if err := l.refreshSession(ctx); err != nil {
|
if err := l.refreshSession(ctx); err != nil {
|
||||||
return nil, err
|
return nil, fmt.Errorf("failed to refresh message session: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
l.logger.Info("Getting next message", "lastMessageID", l.lastMessageID)
|
l.logger.Info("Getting next message", "lastMessageID", l.lastMessageID)
|
||||||
@@ -284,7 +284,7 @@ func (l *Listener) deleteLastMessage(ctx context.Context) error {
|
|||||||
}
|
}
|
||||||
|
|
||||||
if err := l.refreshSession(ctx); err != nil {
|
if err := l.refreshSession(ctx); err != nil {
|
||||||
return err
|
return fmt.Errorf("failed to refresh message session: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
err = l.client.DeleteMessage(
|
err = l.client.DeleteMessage(
|
||||||
|
|||||||
Reference in New Issue
Block a user