Use results for uploading step summaries (#2301)

* Use results service for uploading step summaries * Use results summary over generic results naming convention * Apply suggestions from code review Co-authored-by: Tingluo Huang <[email protected]> * Addressing feedback * Fix merge issue * Remove empty line * Update Results json objects to use snake case * Adding the reference Co-authored-by: Yang Cao <[email protected]> Co-authored-by: Tingluo Huang <[email protected]>
2022-12-14 09:28:33 +01:00
parent 369a4eccad
commit f41f5d259d
8 changed files with 405 additions and 17 deletions
@@ -80,6 +80,7 @@ namespace GitHub.Runner.Worker
        // logging
        long Write(string tag, string message);
        void QueueAttachFile(string type, string name, string filePath);
+        void QueueSummaryFile(string name, string filePath, string stepId);

        // timeline record update methods
        void Start(string currentOperation = null);
@@ -846,6 +847,19 @@ namespace GitHub.Runner.Worker
            _jobServerQueue.QueueFileUpload(_mainTimelineId, _record.Id, type, name, filePath, deleteSource: false);
        }

+        public void QueueSummaryFile(string name, string filePath, string stepId)
+        {
+            ArgUtil.NotNullOrEmpty(name, nameof(name));
+            ArgUtil.NotNullOrEmpty(filePath, nameof(filePath));
+
+            if (!File.Exists(filePath))
+            {
+                throw new FileNotFoundException($"Can't upload (name:{name}) file: {filePath}. File does not exist.");
+            }
+
+            _jobServerQueue.QueueSummaryUpload(_mainTimelineId, _record.Id, stepId, name, filePath, deleteSource: false);
+        }
+
        // Add OnMatcherChanged
        public void Add(OnMatcherChanged handler)
        {
@@ -1085,7 +1099,7 @@ namespace GitHub.Runner.Worker
        {
            if (contextData != null &&
                contextData.TryGetValue(PipelineTemplateConstants.Vars, out var varsPipelineContextData) &&
-                varsPipelineContextData != null && 
+                varsPipelineContextData != null &&
                varsPipelineContextData is DictionaryContextData varsContextData)
            {
                // Set debug variables only when StepDebug/RunnerDebug variables are not present.