start calling run service for job completion (#2412)

* start calling run service for job completion * cleanup * nit: lines Co-authored-by: Tingluo Huang <[email protected]> * clean up * give sanity back to thboop Co-authored-by: Thomas Boop <[email protected]> * add clean up back * clean up * clean up more * oops * copied from existing, but :thumb: Co-authored-by: Thomas Boop <[email protected]> --------- Co-authored-by: Tingluo Huang <[email protected]> Co-authored-by: Thomas Boop <[email protected]>
2023-02-01 21:18:31 +00:00
parent 24a27efd4f
commit e6e5f36dd0
11 changed files with 220 additions and 78 deletions
@@ -68,6 +68,19 @@ namespace GitHub.Runner.Common
            throw new InvalidOperationException(nameof(EstablishVssConnection));
        }

+        protected async Task RetryRequest(Func<Task> func,
+            CancellationToken cancellationToken,
+            int maxRetryAttemptsCount = 5
+        )
+        {
+            async Task<Unit> wrappedFunc()
+            {
+                await func();
+                return Unit.Value;
+            }
+            await RetryRequest<Unit>(wrappedFunc, cancellationToken, maxRetryAttemptsCount);
+        }
+        
        protected async Task<T> RetryRequest<T>(Func<Task<T>> func,
            CancellationToken cancellationToken,
            int maxRetryAttemptsCount = 5
@@ -85,7 +98,7 @@ namespace GitHub.Runner.Common
                // TODO: Add handling of non-retriable exceptions: https://github.com/github/actions-broker/issues/122
                catch (Exception ex) when (retryCount < maxRetryAttemptsCount)
                {
-                    Trace.Error("Catch exception during get full job message");
+                    Trace.Error("Catch exception during request");
                    Trace.Error(ex);
                    var backOff = BackoffTimerHelper.GetRandomBackoff(TimeSpan.FromSeconds(5), TimeSpan.FromSeconds(15));
                    Trace.Warning($"Back off {backOff.TotalSeconds} seconds before next retry. {maxRetryAttemptsCount - retryCount} attempt left.");