Add annotations if Node 12 action is found and FF is on (#1735)
* Add annotations if node 12 action is found * Better placeholder * Only warn if FF is on * Move annotation logic * Pass in the LTS Url * Raise annotation right before executing the action * Match server side FF name * Change name back to features * Better warning text * Update src/Runner.Common/Constants.cs Co-authored-by: Thomas Boop <[email protected]> Co-authored-by: Thomas Boop <[email protected]>
This commit is contained in:
co-authored by
Thomas Boop
parent
46258428cd
commit
408d6c579c
@@ -6,6 +6,7 @@ using System.Net.Http;
|
||||
using System.Text;
|
||||
using System.Threading;
|
||||
using System.Threading.Tasks;
|
||||
using GitHub.DistributedTask.Pipelines.ContextData;
|
||||
using GitHub.DistributedTask.WebApi;
|
||||
using GitHub.Runner.Common;
|
||||
using GitHub.Runner.Common.Util;
|
||||
@@ -257,6 +258,12 @@ namespace GitHub.Runner.Worker
|
||||
}
|
||||
}
|
||||
|
||||
if (jobContext.JobContext.ContainsKey("Node12ActionsWarnings"))
|
||||
{
|
||||
var actions = string.Join(", ", jobContext.JobContext["Node12ActionsWarnings"].AssertArray("Node12ActionsWarnings").Select(action => action.ToString()));
|
||||
jobContext.Warning(string.Format(Constants.Runner.Node12DetectedAfterEndOfLife, actions));
|
||||
}
|
||||
|
||||
try
|
||||
{
|
||||
await ShutdownQueue(throwOnFailure: true);
|
||||
|
||||
Reference in New Issue
Block a user