Allow the container.image to be empty (#2235)

* Allow container.image to be null/empty

* Remove unnecessary workflow type

* Update src/Sdk/DTPipelines/Pipelines/ObjectTemplating/PipelineTemplateConverter.cs

Co-authored-by: Ferenc Hammerl <[email protected]>

* Rename ConvertToJobContainer to ConvertToContainer
It converts serviceContainers too

* Remove unused parameter
AllowExpressions was always false

* Allow service in yaml with empty string for value

* Don't attempt to start services without an image

* Improve error messages

* Revert "Remove unused parameter"

This reverts commit f4ab2d50d0.

* Revert "Rename ConvertToJobContainer to ConvertToContainer"

This reverts commit ffc62f8343.

* Fix revert merge conflict

* Removed info logs

* Added info log for services without container images

Co-authored-by: moonblade <[email protected]>
Co-authored-by: Ferenc Hammerl <[email protected]>
Co-authored-by: Ava Stancu <[email protected]>

This commit is contained in:

JoannaaKL

2022-11-02 11:27:37 +01:00

committed by

GitHub

co-authored by

moonblade

Ferenc Hammerl

Ava Stancu

parent dad7ad0384

commit 3e196355de

3 changed files with 8 additions and 3 deletions

									
										src/Sdk/DTPipelines/Pipelines/ObjectTemplating/PipelineTemplateConverter.cs
									
		+1
		-1
	
												View File
												
				@@ -316,7 +316,7 @@ namespace GitHub.DistributedTask.Pipelines.ObjectTemplating

				            if (String.IsNullOrEmpty(result.Image))

				            {

				                context.Error(value, "Container image cannot be empty");

				                return null;

				            }

				            return result;