0ddbf8cafa
* updated files with docstrings to pass pylint Signed-off-by: Mark Cohen <markcoh@amazon.com> * updated samples to prepare for enabling missing-docstring linter; will continue to work on this before committing setup.cfg Signed-off-by: Mark Cohen <markcoh@amazon.com> * removed missing-function-docstring from setup.cfg so the linter doesn't fail while work on docstrings continues Signed-off-by: Mark Cohen <markcoh@amazon.com> * corrected unnecessary return docstring values Signed-off-by: Mark Cohen <markcoh@amazon.com> * fixing failure in 'black' on reformatting Signed-off-by: Mark Cohen <markcoh@amazon.com> * updated utils to pass missing-function-docstring tests Signed-off-by: Mark Cohen <markcoh@amazon.com> * updated functions with missing docstrings or pylint ignore instructions; added a utility to automatically add these ignore instructions to most functions that should be self-describing; rolled back some automatically generated code mistakenly changed Signed-off-by: Mark Cohen <markcoh@amazon.com> * * ignoring opensearchpy for pylint and then added it back to noxfile.py * fixed some lints; created a feature flag for newer dynamic pylint so now lints can be fixed first in legacy code and then enabled by multiple people * extracted a method for per-folder linting * updated noxfile.lint_per_folder with type hints * enabled unspecified-encoding in pylint * added disable missing-function-docstring pragma to test_clients.py in test_async and test_server * added more encodings to pass unspecified-encoding pylint tests * updated changelog Signed-off-by: Mark Cohen <markcoh@amazon.com> * updated CHANGELOG.md entry removed the feature flag for pylint lint_per_folder fixed failures from mypy and pylint removed pylint MESSAGE CONTROL config from setup.cfg after relocating to lint_per_folder method Signed-off-by: Mark Cohen <markcoh@amazon.com> * removed pylint ignore missing-function-docstring Signed-off-by: Mark Cohen <markcoh@amazon.com> * added pylint.extensions.docparams plugin updated some docstrings to correct parameters removed pylint from setup.cfg Signed-off-by: Mark Cohen <markcoh@amazon.com> * added four lints for opensearchpy/ Signed-off-by: Mark Cohen <markcoh@amazon.com> * adding await back to client.info() call Signed-off-by: Mark Cohen <markcoh@amazon.com> * updated TODOs as requested renamed test_opensearchpy.test_async.test_server.test_helpers.conftest.setup_ubq_tests to setup_update_by_query_tests added OpenSearch-main/rest-api-spec/src/main/resources/rest-api-spec/test/indices/stats/50_noop_update[0] to skip tests list run_tests.py catches a CalledProcessError when the git repo already exists and the command to add the origin fails in fetch_opensearch_repo() Signed-off-by: Mark Cohen <markcoh@amazon.com> --------- Signed-off-by: Mark Cohen <markcoh@amazon.com>
120 lines
3.8 KiB
Python
120 lines
3.8 KiB
Python
# SPDX-License-Identifier: Apache-2.0
|
|
#
|
|
# The OpenSearch Contributors require contributions made to
|
|
# this file be licensed under the Apache-2.0 license or a
|
|
# compatible open source license.
|
|
#
|
|
# Modifications Copyright OpenSearch Contributors. See
|
|
# GitHub history for details.
|
|
|
|
"""Script which verifies that all source files have a license header.
|
|
Has two modes: 'fix' and 'check'. 'fix' fixes problems, 'check' will
|
|
error out if 'fix' would have changed the file.
|
|
"""
|
|
|
|
import os
|
|
import re
|
|
import sys
|
|
from typing import Iterator, List
|
|
|
|
LINES_TO_KEEP = ["#!/usr/bin/env python"]
|
|
|
|
LICENSE_HEADER = """
|
|
# SPDX-License-Identifier: Apache-2.0
|
|
#
|
|
# The OpenSearch Contributors require contributions made to
|
|
# this file be licensed under the Apache-2.0 license or a
|
|
# compatible open source license.
|
|
#
|
|
# Modifications Copyright OpenSearch Contributors. See
|
|
# GitHub history for details.
|
|
""".strip()
|
|
|
|
|
|
def find_files_to_fix(sources: List[str]) -> Iterator[str]:
|
|
"""Iterates over all files and dirs in 'sources' and returns
|
|
only the filepaths that need fixing.
|
|
"""
|
|
for source in sources:
|
|
if os.path.isfile(source) and does_file_need_fix(source):
|
|
yield source
|
|
elif os.path.isdir(source):
|
|
for root, _, filenames in os.walk(source):
|
|
for filename in filenames:
|
|
filepath = os.path.join(root, filename)
|
|
if does_file_need_fix(filepath):
|
|
yield filepath
|
|
|
|
|
|
def does_file_need_fix(filepath: str) -> bool:
|
|
"""
|
|
checks if the correct license header exists at the top of the file
|
|
:param filepath: an absolute or relative filepath to a file to check
|
|
:return: True if the file needs a header, False if it does not
|
|
"""
|
|
if not re.search(r"\.py$", filepath):
|
|
return False
|
|
existing_header = ""
|
|
with open(filepath, mode="r", encoding="utf-8") as file:
|
|
for line in file:
|
|
line = line.strip()
|
|
if len(line) == 0 or line in LINES_TO_KEEP:
|
|
pass
|
|
elif line[0] == "#":
|
|
existing_header += line
|
|
existing_header += "\n"
|
|
else:
|
|
break
|
|
return not existing_header.startswith(LICENSE_HEADER)
|
|
|
|
|
|
def add_header_to_file(filepath: str) -> None:
|
|
"""
|
|
writes the license header to the beginning of a file
|
|
:param filepath: relative or absolute filepath to update
|
|
"""
|
|
with open(filepath, mode="r", encoding="utf-8") as file:
|
|
lines = list(file)
|
|
i = 0
|
|
for i, line in enumerate(lines):
|
|
if len(line) > 0 and line not in LINES_TO_KEEP:
|
|
break
|
|
lines = lines[:i] + [LICENSE_HEADER] + lines[i:]
|
|
with open(filepath, mode="w", encoding="utf-8") as file:
|
|
file.truncate()
|
|
file.write("".join(lines))
|
|
print(f"Fixed {os.path.relpath(filepath, os.getcwd())}")
|
|
|
|
|
|
def main() -> None:
|
|
"""
|
|
arguments:
|
|
fix: find all files without license headers and insert headers at the top of the file
|
|
check: prints a list of files without license headers
|
|
list of one or more directories: search in these directories
|
|
"""
|
|
mode = sys.argv[1]
|
|
assert mode in ("fix", "check")
|
|
sources = [os.path.abspath(x) for x in sys.argv[2:]]
|
|
files_to_fix = find_files_to_fix(sources)
|
|
|
|
if mode == "fix":
|
|
for filepath in files_to_fix:
|
|
add_header_to_file(filepath)
|
|
else:
|
|
no_license_headers = list(files_to_fix)
|
|
if no_license_headers:
|
|
print("No license header found in:")
|
|
cwd = os.getcwd()
|
|
[
|
|
print(f" - {os.path.relpath(filepath, cwd)}")
|
|
for filepath in no_license_headers
|
|
]
|
|
sys.exit(1)
|
|
else:
|
|
print("All files had license header")
|
|
|
|
|
|
if __name__ == "__main__":
|
|
main()
|