* added unnecessary-dunder-call to pylintrc files; disabled for certain lines
in run_tests.py, exception thrown by 'git remote add origin' when the remote already exists will not exit
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* updates to adhere to assignment-from-no-return lint
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* simplified get_value_filter in Facet to return None
added assert to test get_value_filter returning None
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* added option to output HTML test coverage locally from run_tests.py
returning None from test_faceted_search.Facet.get_value_filter
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* added unused-variable lints; replaced unused variables with _ or referenced them
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* updated CHANGELOG to point to the right PR
Signed-off-by: Mark Cohen <markcoh@amazon.com>
---------
Signed-off-by: Mark Cohen <markcoh@amazon.com>
in run_tests.py, exception thrown by 'git remote add origin' when the remote already exists will not exit
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* switched pylint to a .pylintrc based config
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* added invalid-name pylint disable instruction because the framework requires camel case instead of snake case
Signed-off-by: Mark Cohen <markcoh@amazon.com>
---------
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* updated files with docstrings to pass pylint
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* updated samples to prepare for enabling missing-docstring linter; will continue to work on this before committing setup.cfg
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* removed missing-function-docstring from setup.cfg so the linter doesn't fail while work on docstrings continues
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* corrected unnecessary return docstring values
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* fixing failure in 'black' on reformatting
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* updated utils to pass missing-function-docstring tests
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* updated functions with missing docstrings or pylint ignore instructions; added a utility to automatically add these ignore instructions to most functions that should be self-describing; rolled back some automatically generated code mistakenly changed
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* * ignoring opensearchpy for pylint and then added it back to noxfile.py
* fixed some lints; created a feature flag for newer dynamic pylint so now lints can be fixed first in legacy code and then enabled by multiple people
* extracted a method for per-folder linting
* updated noxfile.lint_per_folder with type hints
* enabled unspecified-encoding in pylint
* added disable missing-function-docstring pragma to test_clients.py in test_async and test_server
* added more encodings to pass unspecified-encoding pylint tests
* updated changelog
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* updated CHANGELOG.md entry
removed the feature flag for pylint lint_per_folder
fixed failures from mypy and pylint
removed pylint MESSAGE CONTROL config from setup.cfg after relocating to lint_per_folder method
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* removed pylint ignore missing-function-docstring
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* added pylint.extensions.docparams plugin
updated some docstrings to correct parameters
removed pylint from setup.cfg
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* added four lints for opensearchpy/
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* adding await back to client.info() call
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* updated TODOs as requested
renamed test_opensearchpy.test_async.test_server.test_helpers.conftest.setup_ubq_tests to setup_update_by_query_tests
added
OpenSearch-main/rest-api-spec/src/main/resources/rest-api-spec/test/indices/stats/50_noop_update[0]
to skip tests list
run_tests.py catches a CalledProcessError when the git repo already exists and the command to add the origin fails in fetch_opensearch_repo()
Signed-off-by: Mark Cohen <markcoh@amazon.com>
---------
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Updated CHANGELOG.md.
nox formatting applied.
Added new unit test for actions scan function.
Added type hints & nox formatting.
Added fix to async scan function & added matching unit tests for async.
Signed-off-by: Djcarrillo6 <djcarrillo6@yahoo.com>
* WIP: Added support for AWS Sigv4 for UrlLib3.
Signed-off-by: dblock <dblock@amazon.com>
* Refactored common implementation.
Signed-off-by: dblock <dblock@amazon.com>
* Added sigv4 samples.
Signed-off-by: dblock <dblock@amazon.com>
* Updated CHANGELOG.
Signed-off-by: dblock <dblock@amazon.com>
* Add documentation.
Signed-off-by: dblock <dblock@amazon.com>
* Use the correct class in tests.
Signed-off-by: dblock <dblock@amazon.com>
* Renamed samples.
Signed-off-by: dblock <dblock@amazon.com>
* Split up requests and urllib3 unit tests.
Signed-off-by: dblock <dblock@amazon.com>
* Rename AWSV4Signer.
Signed-off-by: dblock <dblock@amazon.com>
* Clarified documentation of when to use Urllib3AWSV4SignerAuth vs. RequestHttpConnection.
Signed-off-by: dblock <dblock@amazon.com>
* Move fetch_url inside the signer class.
Signed-off-by: dblock <dblock@amazon.com>
* Added unit test for Urllib3AWSV4SignerAuth adding headers.
Signed-off-by: dblock <dblock@amazon.com>
* Added unit test for signing to include query string.
Signed-off-by: dblock <dblock@amazon.com>
---------
Signed-off-by: dblock <dblock@amazon.com>
Passing the Content-Type to `_raise_errors` will cause the json body to
be parsed and included in the `TransportError`.
This matches the behaviour of the sync client.
Fixes#225
Signed-off-by: Gordon Govan <gg@kialo.com>
* Import async helpers through public interface in tests
Signed-off-by: Roger Aiudi <aiudirog@gmail.com>
* Removed unused import of AsyncOpenSearch in async helpers that was causing an import cycle (fixes#310)
Signed-off-by: Roger Aiudi <aiudirog@gmail.com>
* Update CHANGELOG.md
Signed-off-by: Roger Aiudi <aiudirog@gmail.com>
* Change 2.2.1 in the changelog to Unreleased
Signed-off-by: Roger Aiudi <aiudirog@gmail.com>
* Separated changelog entries for 2.2.0 from 2.1.1
Signed-off-by: Roger Aiudi <aiudirog@gmail.com>
---------
Signed-off-by: Roger Aiudi <aiudirog@gmail.com>
* Check OpenSSL environment variables before defaulting to certifi
Signed-off-by: Roger Aiudi <aiudirog@gmail.com>
* Fix formatting
Signed-off-by: Roger Aiudi <aiudirog@gmail.com>
* Moved CA_CERTS to the base Connection module
Signed-off-by: Roger Aiudi <aiudirog@gmail.com>
* Updated requests Connection to use common CA_CERTS by default
Signed-off-by: Roger Aiudi <aiudirog@gmail.com>
* Pass nox linting
Signed-off-by: Roger Aiudi <aiudirog@gmail.com>
* Update CHANGELOG.md and USER_GUIDE.md
Signed-off-by: Roger Aiudi <aiudirog@gmail.com>
* Updated AIOHttpConnection to only load CA_CERTS if verify_certs is True
Signed-off-by: Roger Aiudi <aiudirog@gmail.com>
* Added test cases for CA_CERTS handling in each Connection implementation
Signed-off-by: Roger Aiudi <aiudirog@gmail.com>
* Move CA cert handling to Connection.default_ca_certs()
Add test cases for the different CA cert configurations
Signed-off-by: Roger Aiudi <aiudirog@gmail.com>
* Update actions to test unsupported Python versions on ubuntu-20.04
Signed-off-by: Roger Aiudi <aiudirog@gmail.com>
* Fix Python versions being interpreted as floats
Signed-off-by: Roger Aiudi <aiudirog@gmail.com>
* Workaround Monkeypatch not available on old pytest versions
Signed-off-by: Roger Aiudi <aiudirog@gmail.com>
Signed-off-by: Roger Aiudi <aiudirog@gmail.com>
Co-authored-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
* Added timeout to available input query parameters
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
* Add unit test to ensure that timeout is an accepted parameter
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
* Re-enable integration tests for 1.x versions of OpenSearch
Signed-off-by: Vacha Shah <vachshah@amazon.com>
* Fixing integ tests after re-enabling 1.x versions
Signed-off-by: Vacha Shah <vachshah@amazon.com>
* Separating out versions
Signed-off-by: Vacha Shah <vachshah@amazon.com>
* Breaking changes for type removal
Signed-off-by: Vacha Shah <vachshah@amazon.com>
* Adding support to test against unreleased OpenSearch
Signed-off-by: Vacha Shah <vachshah@amazon.com>
* Formatting
Signed-off-by: Vacha Shah <vachshah@amazon.com>
* Addressing comments to refactor run-opensearch.sh
Signed-off-by: Vacha Shah <vachshah@amazon.com>
Sai Medhini Reddy Maryada