* added unnecessary-dunder-call to pylintrc files; disabled for certain lines
in run_tests.py, exception thrown by 'git remote add origin' when the remote already exists will not exit
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* updates to adhere to assignment-from-no-return lint
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* simplified get_value_filter in Facet to return None
added assert to test get_value_filter returning None
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* added option to output HTML test coverage locally from run_tests.py
returning None from test_faceted_search.Facet.get_value_filter
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* added unused-variable lints; replaced unused variables with _ or referenced them
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* updated CHANGELOG to point to the right PR
Signed-off-by: Mark Cohen <markcoh@amazon.com>
---------
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* updated files with docstrings to pass pylint
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* updated samples to prepare for enabling missing-docstring linter; will continue to work on this before committing setup.cfg
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* removed missing-function-docstring from setup.cfg so the linter doesn't fail while work on docstrings continues
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* corrected unnecessary return docstring values
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* fixing failure in 'black' on reformatting
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* updated utils to pass missing-function-docstring tests
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* updated functions with missing docstrings or pylint ignore instructions; added a utility to automatically add these ignore instructions to most functions that should be self-describing; rolled back some automatically generated code mistakenly changed
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* * ignoring opensearchpy for pylint and then added it back to noxfile.py
* fixed some lints; created a feature flag for newer dynamic pylint so now lints can be fixed first in legacy code and then enabled by multiple people
* extracted a method for per-folder linting
* updated noxfile.lint_per_folder with type hints
* enabled unspecified-encoding in pylint
* added disable missing-function-docstring pragma to test_clients.py in test_async and test_server
* added more encodings to pass unspecified-encoding pylint tests
* updated changelog
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* updated CHANGELOG.md entry
removed the feature flag for pylint lint_per_folder
fixed failures from mypy and pylint
removed pylint MESSAGE CONTROL config from setup.cfg after relocating to lint_per_folder method
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* removed pylint ignore missing-function-docstring
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* added pylint.extensions.docparams plugin
updated some docstrings to correct parameters
removed pylint from setup.cfg
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* added four lints for opensearchpy/
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* adding await back to client.info() call
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* updated TODOs as requested
renamed test_opensearchpy.test_async.test_server.test_helpers.conftest.setup_ubq_tests to setup_update_by_query_tests
added
OpenSearch-main/rest-api-spec/src/main/resources/rest-api-spec/test/indices/stats/50_noop_update[0]
to skip tests list
run_tests.py catches a CalledProcessError when the git repo already exists and the command to add the origin fails in fetch_opensearch_repo()
Signed-off-by: Mark Cohen <markcoh@amazon.com>
---------
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* updated files with docstrings to pass pylint
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* updated samples to prepare for enabling missing-docstring linter; will continue to work on this before committing setup.cfg
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* removed missing-function-docstring from setup.cfg so the linter doesn't fail while work on docstrings continues
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* corrected unnecessary return docstring values
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* fixing failure in 'black' on reformatting
Signed-off-by: Mark Cohen <markcoh@amazon.com>
---------
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Daniel (dB.) Doubrovkine