TransportError not raised in helpers.streaming_bulk() with max_retries. (#775)

* Add test to raise `TransportError` in `helpers.streaming_bulk()` with `max_retries`. * Re-raise `TransportError` if the last retry fails.
2018-04-24 11:35:54 -06:00
parent 0aac8c9dff
commit cd871244e0
2 changed files with 18 additions and 1 deletions
@@ -136,6 +136,23 @@ class TestStreamingBulk(ElasticsearchTestCase):
        self.assertEquals(2, res['hits']['total'])
        self.assertEquals(4, failing_client._called)

+    def test_transport_error_is_raised_with_max_retries(self):
+        failing_client = FailingBulkClient(self.client, fail_at=(1, 2, 3, 4, ),
+                                           fail_with=TransportError(429, 'Rejected!', {}))
+
+        def streaming_bulk():
+            results = list(helpers.streaming_bulk(
+                failing_client,
+                [{"a": 42}, {"a": 39}],
+                raise_on_exception=True,
+                max_retries=3,
+                initial_backoff=0
+            ))
+            return results
+
+        self.assertRaises(TransportError, streaming_bulk)
+        self.assertEquals(4, failing_client._called)
+

 class TestBulk(ElasticsearchTestCase):
    def test_bulk_works_with_single_item(self):