requested changes.

This commit is contained in:
Will McGinnis
2016-03-03 19:50:17 -05:00
parent 8a18e4c743
commit b0d3de0ada
5 changed files with 4 additions and 10 deletions
@@ -92,4 +92,3 @@ class RequestsHttpConnection(Connection):
Explicitly closes connections Explicitly closes connections
""" """
self.session.close() self.session.close()
return True
-1
View File
@@ -118,4 +118,3 @@ class Urllib3HttpConnection(Connection):
Explicitly closes connection Explicitly closes connection
""" """
self.pool.close() self.pool.close()
return True
+1 -1
View File
@@ -29,5 +29,5 @@ class PoolingConnection(Connection):
""" """
Explicitly close connection Explicitly close connection
""" """
return True pass
+2 -5
View File
@@ -231,11 +231,9 @@ class ConnectionPool(object):
""" """
Explicitly closes connections Explicitly closes connections
""" """
for conn in self.connections: for conn in self.orig_connections:
conn.close() conn.close()
return True
class DummyConnectionPool(ConnectionPool): class DummyConnectionPool(ConnectionPool):
def __init__(self, connections, **kwargs): def __init__(self, connections, **kwargs):
if len(connections) != 1: if len(connections) != 1:
@@ -253,8 +251,7 @@ class DummyConnectionPool(ConnectionPool):
""" """
Explicitly closes connections Explicitly closes connections
""" """
for conn in self.connections: self.connection.close()
conn.close()
def _noop(self, *args, **kwargs): def _noop(self, *args, **kwargs):
pass pass
-1
View File
@@ -358,4 +358,3 @@ class Transport(object):
Explcitly closes connections Explcitly closes connections
""" """
self.connection_pool.close() self.connection_pool.close()
return True