Assignment from no return (#658)

* added unnecessary-dunder-call to pylintrc files; disabled for certain lines

in run_tests.py, exception thrown by 'git remote add origin' when the remote already exists will not exit

Signed-off-by: Mark Cohen <[email protected]>

* updates to adhere to assignment-from-no-return lint

Signed-off-by: Mark Cohen <[email protected]>

* simplified get_value_filter in Facet to return None
added assert to test get_value_filter returning None

Signed-off-by: Mark Cohen <[email protected]>

* added option to output HTML test coverage locally from run_tests.py

returning None from test_faceted_search.Facet.get_value_filter

Signed-off-by: Mark Cohen <[email protected]>

* added unused-variable lints; replaced unused variables with _ or referenced them

Signed-off-by: Mark Cohen <[email protected]>

* updated CHANGELOG to point to the right PR

Signed-off-by: Mark Cohen <[email protected]>

---------

Signed-off-by: Mark Cohen <[email protected]>
This commit is contained in:
Mark Cohen
2024-01-25 15:17:09 -08:00
committed by GitHub
parent 900ea94ec8
commit a80bab2ad5
22 changed files with 70 additions and 57 deletions
@@ -341,7 +341,7 @@ class TestAIOHttpConnection:
async def test_surrogatepass_into_bytes(self) -> None:
buf = b"\xe4\xbd\xa0\xe5\xa5\xbd\xed\xa9\xaa"
con = await self._get_mock_connection(response_body=buf)
status, headers, data = await con.perform_request("GET", "/")
_, _, data = await con.perform_request("GET", "/")
assert u"你好\uda6a" == data # fmt: skip
@pytest.mark.parametrize("exception_cls", reraise_exceptions) # type: ignore
@@ -394,7 +394,7 @@ class TestConnectionHttpServer:
cls.server.stop()
async def httpserver(self, conn: Any, **kwargs: Any) -> Any:
status, headers, data = await conn.perform_request("GET", "/", **kwargs)
status, _, data = await conn.perform_request("GET", "/", **kwargs)
data = json.loads(data)
return (status, data)