Assignment from no return (#658)

* added unnecessary-dunder-call to pylintrc files; disabled for certain lines

in run_tests.py, exception thrown by 'git remote add origin' when the remote already exists will not exit

Signed-off-by: Mark Cohen <[email protected]>

* updates to adhere to assignment-from-no-return lint

Signed-off-by: Mark Cohen <[email protected]>

* simplified get_value_filter in Facet to return None
added assert to test get_value_filter returning None

Signed-off-by: Mark Cohen <[email protected]>

* added option to output HTML test coverage locally from run_tests.py

returning None from test_faceted_search.Facet.get_value_filter

Signed-off-by: Mark Cohen <[email protected]>

* added unused-variable lints; replaced unused variables with _ or referenced them

Signed-off-by: Mark Cohen <[email protected]>

* updated CHANGELOG to point to the right PR

Signed-off-by: Mark Cohen <[email protected]>

---------

Signed-off-by: Mark Cohen <[email protected]>

samples/knn/knn_async_basics.py

@@ -56,7 +56,7 @@ async def main() -> None:
     vectors = []
     for i in range(10):
         vec = []
-        for j in range(dimensions):
+        for _ in range(dimensions):
             vec.append(round(random.uniform(0, 1), 2))
 
         vectors.append(
@@ -74,7 +74,7 @@ async def main() -> None:
 
     # search
     vec = []
-    for j in range(dimensions):
+    for _ in range(dimensions):
         vec.append(round(random.uniform(0, 1), 2))
     print(f"Searching for {vec} ...")
 

samples/knn/knn_basics.py

@@ -55,7 +55,7 @@ def main() -> None:
     vectors = []
     for i in range(10):
         vec = []
-        for j in range(dimensions):
+        for _ in range(dimensions):
             vec.append(round(random.uniform(0, 1), 2))
 
         vectors.append(
@@ -72,15 +72,12 @@ def main() -> None:
     client.indices.refresh(index=index_name)
 
     # search
-    vec = []
-    for j in range(dimensions):
-        vec.append(round(random.uniform(0, 1), 2))
+    vec = [round(random.uniform(0, 1), 2) for _ in range(dimensions)]
     print(f"Searching for {vec} ...")
 
     search_query = {"query": {"knn": {"values": {"vector": vec, "k": 3}}}}
     results = client.search(index=index_name, body=search_query)
-    for hit in results["hits"]["hits"]:
-        print(hit)
+    (print(hit) for hit in results["hits"]["hits"])
 
     # delete index
     client.indices.delete(index=index_name)

samples/knn/knn_boolean_filter.py

@@ -56,7 +56,7 @@ def main() -> None:
     genres = ["fiction", "drama", "romance"]
     for i in range(3000):
         vec = []
-        for j in range(dimensions):
+        for _ in range(dimensions):
             vec.append(round(random.uniform(0, 1), 2))
 
         vectors.append(
@@ -76,7 +76,7 @@ def main() -> None:
     # search
     genre = random.choice(genres)
     vec = []
-    for j in range(dimensions):
+    for _ in range(dimensions):
         vec.append(round(random.uniform(0, 1), 2))
     print(f"Searching for {vec} with the '{genre}' genre ...")